fix dropdowns have wrong mark color in browsers #3238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darshan-upadhyay1110
force-pushed
the
private/darshan/missing-cool-theme-element
branch
from
aec36db to
8aa58b3
Compare
Collaborator
Author
|
CC: @juliushaertl can you please review this patch. |
juliusknorr
reviewed
Oct 20, 2023
| // New dark mode compatible way to hand over our Nextcloud variables in both light/dark to Collabora | ||
| const lightElement = document.getElementById('cool-var-source-light') ?? document.documentElement | ||
| const darkElement = document.getElementById('cool-var-source-dark') ?? document.documentElement | ||
| const darkElement = createDataThemeDiv('div', 'dark') |
Member
There was a problem hiding this comment.
Can we also remove those elements after extracting the values again?
juliusknorr
reviewed
Oct 20, 2023
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Small nitpick to cleanup the elements, otherwise tested and works 👍
Member
|
/backport to stable27 |
Member
|
Also eslint is not happy:
|
Darshan-upadhyay1110
force-pushed
the
private/darshan/missing-cool-theme-element
branch
from
8aa58b3 to
f67f25d
Compare
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Darshan-upadhyay1110
force-pushed
the
private/darshan/missing-cool-theme-element
branch
from
f67f25d to
0791c56
Compare
4 tasks
Collaborator
Author
CC: @juliushaertl |
juliusknorr
approved these changes
Oct 20, 2023
juliusknorr
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cool-var-source-lightelement is no longer loaded to office.vueTODO
Checklist