Consolidate and fix migration

[dartcafe]

#424

[nickvergessen]

Works 👍

[nickvergessen]

Also in theory your migrations are named wrongly.
See nextcloud/server#12275 (comment) for the intended schema.

So in theory your files should be called 0009

[dartcafe]

So in theory your files should be called 0009

OMG. You're right.

[dartcafe]

I can change this, but does this affect the migration system, if users installed the RCs?

[nickvergessen]

Since RC is git only, you can do it.
Also your migrations look save enough to not cause troubles, because you check if the table exists before adding it again etc.

But you can simply change the file+class names and run the update locally and see if it does 💥

[dartcafe]

@nickvergessen thanks for help

• updated function names
• removed unused code
• consolidated migrations

[nickvergessen]

Since you never released this yet, consolidating is okay. But in theory you should not do this as soon as it was released. You should also never edit a released migration, just add a new one.

And you file names should be 0009 not 000009. But not too important.

But the && stuff needs changing

[dartcafe]

And you file names should be 0009 not 000009. But not too important.

@nickvergessen I am a nitpicker. :-) So thanks for the hint. I updated the file names.

[dartcafe]

Since you never released this yet, consolidating is okay. But in theory you should not do this as soon as it was released. You should also never edit a released migration, just add a new one.

@nickvergessen This was indeed because this was never released. I just wanted to make it more handy for the initial use of the migration system.

Removed th second table check.

[nickvergessen]

👍🏼