Skip to content

[stable31] feat(preview): Improve preview management #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
backportbot wants to merge 5 commits into
base: stable31
Choose a base branch
from
Draft

[stable31] feat(preview): Improve preview management #3372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f57497b
fix(preview): Properly access blurhash value
artonge Jan 16, 2026
3bcb942
feat(preview): Do not request small preview if blurhash exists
artonge Jan 16, 2026
043611e
feat(preview): Use smaller previews on mobile
artonge Jan 16, 2026
5af5ee6
chore(preview): Remove distance condition
artonge Jan 16, 2026
7c56529
fix(preview): Do not generate blurhash if large preview is cached
artonge Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/Collection/CollectionContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,10 @@
:file-ids="sortedCollectionFileIds"
:base-height="isMobile ? 120 : 200"
:loading="loading">
<File slot-scope="{file, distance}"

Check failure on line 33 in src/components/Collection/CollectionContent.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

'distance' is defined but never used
:file="files[file.id]"
:allow-selection="allowSelection"
:selected="selection[file.id] === true"
:distance="distance"
@click="openViewer"
@select-toggled="onFileSelectToggle" />
</FilesListViewer>
Expand Down
19 changes: 11 additions & 8 deletions src/components/File.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
:key="`${file.basename}-small`"
:src="srcSmall"
:alt="file.basename"
:decoding="loadedSmall || isVisible ? 'sync' : 'async'"
:fetchpriority="loadedSmall || isVisible ? 'high' : 'low'"
:loading="loadedSmall || isVisible ? 'eager' : distance < 2 ? 'auto' : 'lazy'"
:decoding="loadedSmall ? 'sync' : 'async'"
:fetchpriority="loadedSmall ? 'high' : 'low'"
:loading="loadedSmall ? 'eager' : undefined"
@load="onLoadSmall"
@error="onErrorSmall">

Expand All @@ -45,9 +45,9 @@
:key="`${file.basename}-large`"
:src="srcLarge"
:alt="file.basename"
:decoding="loadedLarge || isVisible ? 'sync' : 'async'"
:fetchpriority="loadedLarge || isVisible ? 'high' : 'low'"
:loading="loadedLarge || isVisible ? 'auto' : 'lazy'"
:decoding="loadedLarge ? 'sync' : 'async'"
:fetchpriority="loadedLarge ? 'high' : 'low'"
:loading="loadedLarge ? undefined : 'lazy'"
@load="onLoadLarge"
@error="onErrorLarge">
</template>
Expand Down Expand Up @@ -112,6 +112,7 @@
errorSmall: false,
loadedLarge: false,
errorLarge: false,
isMobile: useIsMobile(),

Check failure on line 115 in src/components/File.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

'useIsMobile' is not defined
}
},

Expand Down Expand Up @@ -316,7 +317,9 @@
}

// Reveal checkbox on hover.
&:hover, &.selected, &:focus-within {
&:hover,
&.selected,
&:focus-within {
.selection-checkbox {
opacity: 1;
}
Expand All @@ -335,7 +338,7 @@
z-index: 1;
width: fit-content;

:deep .checkbox-radio-switch__input:focus-visible + .checkbox-radio-switch__content,
:deep .checkbox-radio-switch__input:focus-visible+.checkbox-radio-switch__content,
.checkbox-radio-switch__input:focus-visible {
outline: 2px solid var(--color-main-text);
box-shadow: 0 0 0 3px var(--color-main-background);
Expand Down
2 changes: 1 addition & 1 deletion src/components/FilesListViewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<!-- Placeholder when initial loading -->
<div v-if="showPlaceholders" class="files-list-viewer__placeholder" />
<!-- Real file. -->
<slot v-else :file="item" :distance="row.distance" />
<slot v-else :file="item" />
</li>
</template>
</ul>
Expand Down
1 change: 0 additions & 1 deletion src/components/PhotosPicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
:scroll-to-section="targetMonth"
@need-content="getFiles"
@focusout.native="onFocusOut">
<template slot-scope="{file, height, isHeader, distance}">

Check failure on line 78 in src/components/PhotosPicker.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

'distance' is defined but never used
<h3 v-if="isHeader"
:id="`photos-picker-section-header-${file.id}`"
:style="{ height: `${height}px`}"
Expand All @@ -87,7 +87,6 @@
:file="files[file.id]"
:allow-selection="true"
:selected="selection[file.id] === true"
:distance="distance"
@select-toggled="onFileSelectToggle" />
</template>
</FilesListViewer>
Expand Down
1 change: 0 additions & 1 deletion src/views/FaceContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,10 @@
:container-element="appContent"
:file-ids="faceFileIds"
:loading="loadingFiles || loadingFaces">
<File slot-scope="{file, distance}"

Check failure on line 111 in src/views/FaceContent.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

'distance' is defined but never used
:file="files[file.id]"
:allow-selection="true"
:selected="selection[file.id] === true"
:distance="distance"
@click="openViewer"
@select-toggled="onFileSelectToggle" />
</FilesListViewer>
Expand Down
1 change: 0 additions & 1 deletion src/views/TagContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,10 @@
:file-ids="fileIds"
:base-height="isMobile ? 120 : 200"
:loading="loading">
<File slot-scope="{file, distance}"

Check failure on line 37 in src/views/TagContent.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

'distance' is defined but never used
:file="files[file.id]"
:allow-selection="true"
:selected="selection[file.id] === true"
:distance="distance"
@click="openViewer"
@select-toggled="onFileSelectToggle" />
</FilesListViewer>
Expand Down
1 change: 0 additions & 1 deletion src/views/Timeline.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
:base-height="isMobile ? 120 : 200"
:empty-message="t('photos', 'No photos or videos in here')"
@need-content="getContent">
<template slot-scope="{file, isHeader, distance}">

Check failure on line 98 in src/views/Timeline.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

'distance' is defined but never used
<h2 v-if="isHeader"
:id="`file-picker-section-header-${file.id}`"
class="section-header">
Expand All @@ -106,7 +106,6 @@
:file="files[file.id]"
:allow-selection="true"
:selected="selection[file.id] === true"
:distance="distance"
@click="openViewer"
@select-toggled="onFileSelectToggle" />
</template>
Expand Down
1 change: 0 additions & 1 deletion src/views/UnassignedFaces.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,10 @@
:container-element="appContent"
:file-ids="faceFileIds"
:loading="loadingFiles || loadingFaces">
<File slot-scope="{file, distance}"

Check failure on line 71 in src/views/UnassignedFaces.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

'distance' is defined but never used
:file="files[file.id]"
:allow-selection="true"
:selected="selection[file.id] === true"
:distance="distance"
@click="openViewer"
@select-toggled="onFileSelectToggle" />
</FilesListViewer>
Expand Down
Loading