Skip to content

[stable31] fix(Album): Do not close the form on rename error #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 1 commit into from
Nov 14, 2025
Merged

[stable31] fix(Album): Do not close the form on rename error #3294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/components/Albums/AlbumForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@
methods: {
...mapActions(['createCollection', 'renameCollection', 'updateCollection']),

/** @param {import('../../store/albums.js').Collaborator[]} collaborators */

Check warning on line 200 in src/components/Albums/AlbumForm.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Missing JSDoc @param "collaborators" description
submit(collaborators = []) {
if (!this.canSubmit) {
return
Expand All @@ -210,7 +210,7 @@
}
},

/** @param {import('../../store/albums.js').Collaborator[]} collaborators */

Check warning on line 213 in src/components/Albums/AlbumForm.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Missing JSDoc @param "collaborators" description
async handleCreateAlbum(collaborators = []) {
try {
this.loading = true
Expand Down Expand Up @@ -256,6 +256,10 @@

if (this.album.basename !== this.albumName) {
album = await this.renameCollection({ collectionFileName: this.album.filename, newBaseName: this.albumName })

if (album === this.album) {
return // Abort, and do not close the form if renaming failed
}
}

if (this.album.location !== this.albumLocation) {
Expand Down Expand Up @@ -303,7 +307,8 @@
justify-content: space-between;
flex-direction: column;

.left-buttons, .right-buttons {
.left-buttons,
.right-buttons {
display: flex;
gap: calc(var(--default-grid-baseline) * 4);
}
Expand Down
Loading