Skip to content

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented Apr 10, 2025

Minimal changes to switch to vite.
Better reviewed per commit.

artonge added 2 commits April 10, 2025 10:31
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge self-assigned this Apr 10, 2025
@artonge artonge added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file javascript Javascript related ticket labels Apr 10, 2025
@artonge artonge added this to the Nextcloud 32 milestone Apr 10, 2025
@artonge artonge force-pushed the artonge/chore/use_vite branch 2 times, most recently from 844b366 to dc13cc5 Compare April 10, 2025 08:49
@codecov
Copy link

codecov bot commented Apr 10, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@artonge artonge force-pushed the artonge/chore/use_vite branch 2 times, most recently from 22c1cbd to db43d2f Compare April 10, 2025 09:49
artonge added 3 commits April 10, 2025 12:03
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/chore/use_vite branch 2 times, most recently from 757ffa3 to 42c1565 Compare April 10, 2025 10:07
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/chore/use_vite branch from 42c1565 to 5b64e48 Compare April 10, 2025 11:13
@artonge artonge requested review from skjnldsv and susnux April 10, 2025 11:19
@artonge artonge added the technical debt Technical issue label Apr 22, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed with vite anymore (as you also replaced jest with vitest)

@@ -90,29 +91,24 @@
"@nextcloud/cypress": "^1.0.0-beta.12",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

babel config above not needed anymore

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(if cypress is also using vite)

@susnux susnux merged commit 1a049a2 into master Apr 23, 2025
51 checks passed
@susnux susnux deleted the artonge/chore/use_vite branch April 23, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews dependencies Pull requests that update a dependency file javascript Javascript related ticket technical debt Technical issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants