Skip to content

Allow to hide "People" nav entry for admin - #2228

Merged
artonge merged 2 commits into
masterfrom
artonge/feat/allow_hide_people_nav_entry
Jan 4, 2024
Merged

artonge merged 2 commits into
masterfrom
artonge/feat/allow_hide_people_nav_entry

Conversation

@artonge

@artonge artonge commented Jan 2, 2024 •

Copy link
Copy Markdown
Collaborator

Currently, the "People" navigation entry is advertised to administrators.
This PR adds a config switch to remove this entry.

@artonge artonge added enhancement New feature or request 3. to review Waiting for reviews php PHP related ticket javascript Javascript related ticket labels Jan 2, 2024
@artonge artonge added this to the Nextcloud 29 milestone Jan 2, 2024
@artonge
artonge requested a review from skjnldsv January 2, 2024 15:36
@artonge artonge self-assigned this Jan 2, 2024
@backportbot-nextcloud backportbot-nextcloud Bot added the backport-request Pending backport by the backport-bot label Jan 2, 2024
@artonge
artonge enabled auto-merge January 2, 2024 15:53
@artonge
artonge requested a review from marcelklehr January 2, 2024 15:56
@artonge
artonge disabled auto-merge January 2, 2024 16:52
@artonge
artonge force-pushed the artonge/feat/allow_hide_people_nav_entry branch 2 times, most recently from 27bb2f6 to 033cff5 Compare January 2, 2024 19:54
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
artonge force-pushed the artonge/feat/allow_hide_people_nav_entry branch from 033cff5 to ee3a46c Compare January 3, 2024 19:27
@artonge
artonge requested a review from Pytal January 3, 2024 22:33
@artonge

artonge commented Jan 3, 2024

Copy link
Copy Markdown
Collaborator Author

/compile /

@artonge artonge changed the title Allow to hide People nav entry for admin Allow to hide "People" nav entry for admin Jan 3, 2024
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@artonge
artonge merged commit 6682968 into master Jan 4, 2024
@artonge
artonge deleted the artonge/feat/allow_hide_people_nav_entry branch January 4, 2024 09:32
@artonge

artonge commented Jan 4, 2024

Copy link
Copy Markdown
Collaborator Author

/backport ee3a46c to stable28

@artonge

artonge commented Jan 4, 2024

Copy link
Copy Markdown
Collaborator Author

/backport ee3a46c to stable27

@artonge

artonge commented Jan 4, 2024

Copy link
Copy Markdown
Collaborator Author

/backport ee3a46c to stable26

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud backportbot-nextcloud Bot removed the backport-request Pending backport by the backport-bot label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket php PHP related ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants