Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further optimize preview rendering #1664

Merged
merged 5 commits into from
May 9, 2023
Merged

Further optimize preview rendering #1664

merged 5 commits into from
May 9, 2023

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Feb 28, 2023 •
edited
Loading

  • Delegate loading priority to the browser
  • Check cache if previews are already loaded

Tip: easier to review per commit.

@artonge artonge added javascript Javascript related ticket 2. developing Work in progress performances Performances issues and optimisations labels Feb 28, 2023
@artonge artonge added this to the Nextcloud 26 milestone Feb 28, 2023
@artonge artonge self-assigned this Feb 28, 2023
@artonge artonge marked this pull request as draft February 28, 2023 09:43
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@artonge artonge force-pushed the artonge/feat/optimze_preview_rendering_2 branch from 87316de to d17a77c Compare April 26, 2023 07:49
@skjnldsv skjnldsv mentioned this pull request May 3, 2023
Merged
@artonge artonge force-pushed the artonge/feat/optimze_preview_rendering_2 branch from 3896515 to 7d9a053 Compare May 4, 2023 12:07
@artonge artonge marked this pull request as ready for review May 4, 2023 12:13
@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 4, 2023
@artonge artonge force-pushed the artonge/feat/optimze_preview_rendering_2 branch 2 times, most recently from 1218892 to 118dba4 Compare May 4, 2023 14:29
@artonge artonge requested a review from skjnldsv May 4, 2023 16:26
@artonge artonge force-pushed the artonge/feat/optimze_preview_rendering_2 branch from e423a31 to 8685a49 Compare May 6, 2023 16:37
@skjnldsv
Copy link
Member

skjnldsv commented May 9, 2023

If you have any good tip for Files after your expertise with this PR, I'll take them 🙏 🙇

This was referenced May 9, 2023
Closed
Merged
@artonge
Replace visibility by distance
02a0f6e 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Use native html logic to prioritize loading
5677643 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Remove preview semaphore
85021c5 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Fix folders view
8819f9c 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Compile assets
4399732 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge enabled auto-merge May 9, 2023 09:38
@artonge artonge force-pushed the artonge/feat/optimze_preview_rendering_2 branch from 8685a49 to 4399732 Compare May 9, 2023 09:38
@artonge artonge merged commit 7308b8a into master May 9, 2023
@artonge artonge deleted the artonge/feat/optimze_preview_rendering_2 branch May 9, 2023 14:09
@artonge
Copy link
Collaborator Author

artonge commented May 9, 2023

/backport 8819f9c to stable26

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label May 9, 2023
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 9, 2023
Merged
1 task
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label May 9, 2023
@AndyScherzinger
Copy link
Member

@artonge has this also been backported to 25?

@artonge
Copy link
Collaborator Author

artonge commented May 22, 2023

No, and looks like I also did not backport to 26. I probably considered this too big of a change to be backported, and it is also not a bug fix.
If really needed, I can backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews javascript Javascript related ticket performances Performances issues and optimisations
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
4 participants
@artonge @skjnldsv @AndyScherzinger @blizzz