-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Photos 2.0 #1157
Photos 2.0 #1157
Conversation
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Bumps [@nextcloud/axios](https://github.com/nextcloud/nextcloud-axios) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/nextcloud/nextcloud-axios/releases) - [Changelog](https://github.com/nextcloud/nextcloud-axios/blob/master/CHANGELOG.md) - [Commits](nextcloud-libraries/nextcloud-axios@v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: "@nextcloud/axios" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Add Albums view
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Co-authored-by: Louis <6653109+artonge@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Co-authored-by: Louis <6653109+artonge@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
/compile amend /js |
5ae8c8b
to
a719020
Compare
Signed-off-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stylelint is not happy but that should be easy to fix
/compile amend /js |
Signed-off-by: Marcel Klehr <mklehr@gmx.net> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
075a553
to
60a5b1d
Compare
Would this part have updated the /apps/photos view? If so, could I report that within Chrome, in the /apps/photos view if you scroll far down the "All Media" page, open an image it will reset your position in the page. This means if you leave the image it will return you to the top of the page. In Firefox however this is fine and opening an image does not cause you to be returned to the top of the page. |
Not sure if related, but the /app/photos view also has messed with the ordering of images in the layout. Previously the view would display items in the most recently modified/recently added. The DAV query seems to be working correctly. For example, the first items are: <d:response>
<d:href>/<redacted>/01_TD_1.jpg</d:href>
<d:propstat>
<d:prop>
<oc:fileid>14270471</oc:fileid>
<d:getlastmodified>Sat, 27 Aug 2022 13:40:59 GMT</d:getlastmodified>
<d:getetag>"c71bd8b70533133097c425313a719546"</d:getetag>
<d:getcontenttype>image/jpeg</d:getcontenttype>
<d:getcontentlength>2110878</d:getcontentlength>
<nc:has-preview>true</nc:has-preview>
<nc:file-metadata-size>{"width":1365,"height":2048}</nc:file-metadata-size>
<oc:favorite>0</oc:favorite>
<d:resourcetype/>
</d:prop>
<d:status>HTTP/1.1 200 OK</d:status>
</d:propstat>
<d:propstat>
<d:prop>
<nc:realpath/>
<nc:face-detections/>
</d:prop>
<d:status>HTTP/1.1 404 Not Found</d:status>
</d:propstat>
</d:response>
<d:response>
<d:href>/<redacted>//<redacted>/.jpg</d:href>
<d:propstat>
<d:prop>
<oc:fileid>14270419</oc:fileid>
<d:getlastmodified>Sat, 27 Aug 2022 13:40:46 GMT</d:getlastmodified>
<d:getetag>"76a3ca3a325df858b4cfacd6944b266d"</d:getetag>
<d:getcontenttype>image/jpeg</d:getcontenttype>
<d:getcontentlength>1762165</d:getcontentlength>
<nc:has-preview>true</nc:has-preview>
<nc:file-metadata-size>{"width":1306,"height":1935}</nc:file-metadata-size>
<oc:favorite>0</oc:favorite>
<d:resourcetype/>
</d:prop>
<d:status>HTTP/1.1 200 OK</d:status>
</d:propstat>
<d:propstat>
<d:prop>
<nc:realpath/>
<nc:face-detections/>
</d:prop>
<d:status>HTTP/1.1 404 Not Found</d:status>
</d:propstat>
</d:response> However, in the photos view, we're getting these files first. Suggesting perhaps it's ordering the wrong way around maybe? <d:response>
<d:href>/<redacted>/Red_x5000-450x634.jpg</d:href>
<d:propstat>
<d:prop>
<oc:fileid>14245079</oc:fileid>
<d:getlastmodified>Fri, 26 Aug 2022 10:20:43 GMT</d:getlastmodified>
<d:getetag>"51ace037a58e2be631948ce5fb76e319"</d:getetag>
<d:getcontenttype>image/jpeg</d:getcontenttype>
<d:getcontentlength>149554</d:getcontentlength>
<nc:has-preview>true</nc:has-preview>
<nc:file-metadata-size>{"width":450,"height":634}</nc:file-metadata-size>
<oc:favorite>0</oc:favorite>
<d:resourcetype/>
</d:prop>
<d:status>HTTP/1.1 200 OK</d:status>
</d:propstat>
<d:propstat>
<d:prop>
<nc:realpath/>
<nc:face-detections/>
</d:prop>
<d:status>HTTP/1.1 404 Not Found</d:status>
</d:propstat>
</d:response>
<d:response>
<d:href>/<redacted>/Red_x5000-501x705.jpg</d:href>
<d:propstat>
<d:prop>
<oc:fileid>14245080</oc:fileid>
<d:getlastmodified>Fri, 26 Aug 2022 10:20:42 GMT</d:getlastmodified>
<d:getetag>"e3c1239146083d387ac22dd32cec6919"</d:getetag>
<d:getcontenttype>image/jpeg</d:getcontenttype>
<d:getcontentlength>177274</d:getcontentlength>
<nc:has-preview>true</nc:has-preview>
<nc:file-metadata-size>{"width":501,"height":705}</nc:file-metadata-size>
<oc:favorite>0</oc:favorite>
<d:resourcetype/>
</d:prop>
<d:status>HTTP/1.1 200 OK</d:status>
</d:propstat>
<d:propstat>
<d:prop>
<nc:realpath/>
<nc:face-detections/>
</d:prop>
<d:status>HTTP/1.1 404 Not Found</d:status>
</d:propstat>
</d:response> |
@valdearg Nextcloud 25 ? |
Yes, 25.0.0 beta 3. |
Hello @valdearg I couldn't reproduce you issue. Please fill an issue and provide as many details as possible, so we can understand what's wrong. Same thing with your other issue about ordering. |
Ready to merge as soon as psalm warnings are solved.