Skip to content

Use notification main link if no parameter has a link #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2021
Merged

Use notification main link if no parameter has a link #883

merged 1 commit into from
Mar 8, 2021

Conversation

@julien-nc
Copy link
Member

Maybe I didn't get it but if main notification link and rich parameter links are mutually exclusive (to avoid nested links I guess), there is a mistake here 😁.

If I indeed didn't get it, I can still testify: the main link is not used with a basic notification definition like:

$notification->setParsedSubject($subject)
    ->setLink($link)
    ->setIcon('blabla');

use notification main link if no parameter has a link
872c85d 
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc julien-nc added this to the Nextcloud 22 milestone Mar 8, 2021
ChristophWurst
ChristophWurst approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐘

nickvergessen
nickvergessen approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look right, but didn't test

@nickvergessen
Copy link
Member

And yeah they should be mutual exclusive to avoid nesting.

@ChristophWurst ChristophWurst merged commit ce2ad53 into master Mar 8, 2021
@ChristophWurst ChristophWurst deleted the fix/use-link branch March 8, 2021 13:39
@nickvergessen
Copy link
Member

/backport to stable21

@nickvergessen
Copy link
Member

/backport to stable20

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 2, 2021
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 2, 2021
Merged
@nickvergessen nickvergessen mentioned this pull request Jul 2, 2021
Closed
@szaimen szaimen mentioned this pull request Jul 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

3. to review bug feature: frontend 🖌️

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

4 participants

@julien-nc @nickvergessen @ChristophWurst