Fix header icon hover & focus feedback #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
requested review from
jakobroehrl,
juliusknorr,
nickvergessen and
skjnldsv
skjnldsv
approved these changes
Dec 3, 2019
|
I guess Travis can be ignored since not running on CSS anyway? |
Yes |
|
/backport stable17 Edit: Jeez why doesn’t this work :D |
|
/backport to stable17 |
|
backport to stable17 in #495 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notifications icon was the only icon in the header which didn’t have any hover/focus feedback, or rather the code was not working as intended. :)
Please review @nickvergessen @jakobroehrl @juliushaertl @skjnldsv
I would say this is also good to backport to stable17 as it is an accessibility fix.