Skip to content

[stable31] fix(build): avoid double load of the app #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

[stable31] fix(build): avoid double load of the app #2309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions vite.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,26 @@ export default createAppConfig({
},
includeSourceMaps: true,
},
config: {
build: {
rollupOptions: {
output: {
manualChunks: (id) => {
// By default, Vite stores __vitePreload in the entrypoint
// Then chunks import entrypoint to get the _vitePreload function
// Which results not only in cyclic import but also duplicated module in production
// Because in production entrypoints must be imported with ?v=hash cache busting
// See: https://github.com/nextcloud/notifications/issues/2164
//
// To avoid it - explicitly exclude the preload helper to a separate chunk
//
// TODO: add to @nextcloud/vite-config
if (id.startsWith('\0vite/preload-helper')) {
return 'vite-preload-helper'
}
},
},
},
},
},
})