Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sounds): play call notification sound on second output device #1974

Merged
merged 4 commits into from
Jul 24, 2024
Merged

feat(sounds): play call notification sound on second output device #1974

merged 4 commits into from
Jul 24, 2024

Conversation

Antreesy
Copy link
Collaborator

@Antreesy Antreesy commented Jul 10, 2024 •
edited
Loading

Changes

User settings -> Notifications

Normal browser Safari
image image

TODO

  • If secondary is the same as default, sound will be echoed (because played twice). We can not check if it's the same output or not (default is '', selected by us always has an id) - added an attempt to compare primary and secondary devices
  • Add storage reset
  • Add note for Safari (not supported)
  • Request permissions on audio devices and stop tracking them after receiving
  • Add user documentation
  • Test on:
    • Chrome
    • Firefox
    • Edge (with Grigorii(
    • Safari - does not enumerate output devices, therefore missing this feature
  • Replicate to Talk Desktop
  • Backport to stable29?

@Antreesy Antreesy added this to the Nextcloud 30 milestone Jul 10, 2024
@Antreesy Antreesy self-assigned this Jul 10, 2024
@nickvergessen nickvergessen marked this pull request as draft July 11, 2024 08:19
@Antreesy
chore(deps): install ua-parser-js library v1.0.38
f74b58a 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/871/call-sound-second-device branch from 399555b to ae10fd5 Compare July 24, 2024 13:33
@Antreesy Antreesy requested a review from ShGKme July 24, 2024 13:34
@Antreesy
feat(sounds): add local user setting for secondary audio output devic…
de75a4a 
…e to ring when call notification arrives

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
feat(sounds): play call sound on secondary output device if set up
a4340e8 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/871/call-sound-second-device branch from f5fc8ce to a4340e8 Compare July 24, 2024 15:53
@Antreesy

This comment was marked as outdated.

Sign in to view
@Antreesy Antreesy marked this pull request as ready for review July 24, 2024 15:56
@Antreesy

This comment was marked as outdated.

Sign in to view
nickvergessen
nickvergessen approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't judge the code, but seems to work

@nickvergessen
Copy link
Member

/compile amend /

@nickvergessen
Copy link
Member

/compile /

@nickvergessen
Copy link
Member

/compile amend /

@Antreesy @nextcloud-command
chore: compile assets
0f470b2 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the feat/871/call-sound-second-device branch from 4014d4d to 0f470b2 Compare July 24, 2024 19:00
@nickvergessen nickvergessen merged commit f233a2a into master Jul 24, 2024
37 checks passed
@nickvergessen nickvergessen deleted the feat/871/call-sound-second-device branch July 24, 2024 19:02
@blizzz blizzz mentioned this pull request Jul 25, 2024
Merged
@Antreesy Antreesy mentioned this pull request Aug 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: frontend 🖌️
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @nickvergessen