Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

techdebt(noid): Update nextcloud/coding-standards to 1.2 #1807

Merged
merged 2 commits into from
Feb 1, 2024
Merged

techdebt(noid): Update nextcloud/coding-standards to 1.2 #1807

merged 2 commits into from
Feb 1, 2024

Conversation

nickvergessen
Copy link
Member

No description provided.

@nickvergessen nickvergessen added this to the Nextcloud 29 milestone Feb 1, 2024
@nickvergessen nickvergessen self-assigned this Feb 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 10986 was 10000 (+9.85%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen
techdebt(noid): Update nextcloud/coding-standards to 1.2
7aeb4e2 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(CS): Apply automatic coding standard fixes
511a436 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the techdebt/noid/update-coding-style branch from f22cae4 to 511a436 Compare February 1, 2024 14:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 10985 was 10000 (+9.85%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen merged commit ae1ed91 into master Feb 1, 2024
36 checks passed
@nickvergessen nickvergessen deleted the techdebt/noid/update-coding-style branch February 1, 2024 20:18
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: backend 🛠️ technical debt
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
1 participant
@nickvergessen