Skip to content

Expose image api for other clients as api v1.4 #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

newhinton
Copy link
Contributor

This allows external apps to resolve images.

Could someone please test the api-endpoints? They have been very unreliable for me, though i dont know why. The actual code behind the endpoint works, and is identical to the internal api.

Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
@juliusknorr juliusknorr self-requested a review November 7, 2023 20:13
@juliusknorr juliusknorr added enhancement New feature or request 3. to review labels Nov 7, 2023
@cheywood
Copy link

As a consumer of the API we're looking forward to this MR for #826 👍

@joshtrichards joshtrichards added the feature: API Related to the API for 3rd-party apps, i.e. Android or iOS label Aug 9, 2024
@blizzz blizzz requested a review from a team March 26, 2025 16:56
@Pauldb8
Copy link

Pauldb8 commented Apr 15, 2025

We're looking forward to this merge to for the support to Iotas application for seeing / adding pictures. Thank you very much !

Signed-off-by: Enjeck <32180937+enjeck@users.noreply.github.com>
@enjeck
Copy link
Contributor

enjeck commented Apr 26, 2025

Doesn't seem to work for me, but it might be that I'm not using the API right. I make a request and get no response:

curl -u admin:admin \
  "http://nextcloud.local/apps/notes/api/v1.4/attachment/135?path=img.png"

Nothing from using the image folder either:

curl -u admin:admin \
  "http://nextcloud.local/apps/notes/api/v1.4/attachment/135?path=.attachments.135/img.png"

Using other versions of API instead of v1.4 doesn't work either. But I confirmed note does exist with attachment:

curl -u admin:admin \
  "http://nextcloud.local/apps/notes/api/v1/notes/135"                                       
{"id":135,"title":"New note","modified":1745697329,"category":"test","favorite":false,"readonly":false,"internalPath":"\/Notes\/test\/New note.md","shareTypes":[],"isShared":false,"error":false,"errorType":"","content":"test\n\n![img.png](.attachments.135\/img.png)","etag":"56029a81f877364a391d6c686f3351d0"}% 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing enhancement New feature or request feature: API Related to the API for 3rd-party apps, i.e. Android or iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants