Update update.sh - 32bit architecture check #1648
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an architecture check that stops the updater should it detect a 32bit architecture that is trying to update beyond the latest version for Nextcloud 24, which is the final version with 32bit support. It will also check what the currently latest version is for NC24 from Nextcloud's changelog website. Signed-off-by: Owl <12261439+ZendaiOwl@users.noreply.github.com>
victor-rays
added
the
disruption
1 task
1 task
Prevent update to NC25 for 32bit Signed-off-by: Owl <12261439+ZendaiOwl@users.noreply.github.com>
Removed the double-quotes here Signed-off-by: Owl <12261439+ZendaiOwl@users.noreply.github.com>
|
25.0.2 stable now released should support 32-bit hardware until 26.0.0 and my understanding is nc has decided to include a check to prevent all 32-bit systems from upgrading to 26* once it lands... we will see whether that actually happens, but an fyi. |
|
Closing this for now, since 32bit was reintroduced for version 25, can look into it later on again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an architecture check that stops the updater should it detect a 32bit architecture that is trying to update beyond the latest version for Nextcloud 24, which is the final version with 32bit support.
It will also check what the currently latest version is for NC24 from Nextcloud's changelog website.
I think this should be enough to prevent 32bit systems from updating beyond a supported release but it would be much appreciated if someone with a 32bit system could actually confirm this 🙏
I have tested it locally by changing the variables to my "amd64" system and "pretending" it is a 32bit one.
Signed-off-by: Owl 12261439+ZendaiOwl@users.noreply.github.com