Skip to content

fix: use @nextcloud/moment for formatted date strings #3149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

fix: use @nextcloud/moment for formatted date strings #3149

merged 1 commit into from
Apr 21, 2025
+58 −60

Conversation

@wofferl
Copy link
Collaborator

@wofferl wofferl commented Apr 21, 2025

Summary

This PR fixes incorrect relative date strings like '1 days ago' or '1 years ago'.
It also changes that the nextcloud user settings locale is used, instead of the browser locale.

Checklist

@wofferl
fix: use @nextcloud/moment for formatted date strings
2a08822 
Signed-off-by: Wolfgang <github@linux-dude.de>
@wofferl wofferl added the frontend impact Javascript/Frontend code label Apr 21, 2025
@wofferl wofferl merged commit 27b575d into nextcloud:master Apr 21, 2025
26 checks passed
Grotax added a commit that referenced this pull request May 2, 2025
@Grotax
Release 26.0.0-beta.1
cb529f0 
Changed
- Drop support for Nextcloud 29 (#3146)

Fixed
- respect global `disable all keyboard shortcuts` setting (#3142)
- disable shortcuts in input fields from global overlays (e.g. Nextcloud assistant) (#3142)
- fix relative date strings (#3149)
- Switching between folders in compact mode doesn't close actual selected item (#3150)
- current selected article is removed from the list after showing details in mobile mode (#3150)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax mentioned this pull request May 2, 2025
Merged
Grotax added a commit that referenced this pull request May 2, 2025
@Grotax
Release 26.0.0-beta.1
d621763 
Changed
- Drop support for Nextcloud 29 (#3146)

Fixed
- respect global `disable all keyboard shortcuts` setting (#3142)
- disable shortcuts in input fields from global overlays (e.g. Nextcloud assistant) (#3142)
- fix relative date strings (#3149)
- Switching between folders in compact mode doesn't close actual selected item (#3150)
- current selected article is removed from the list after showing details in mobile mode (#3150)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Juri-w added a commit to Juri-w/news that referenced this pull request May 5, 2025
@Juri-w
Squashed commit of the following:
644442e 
commit 3f2f1b3
Author: Wolfgang <github@linux-dude.de>
Date:   Sat May 3 12:24:54 2025 +0200

    fix: item list not updated by automatic or manual refresh

    Signed-off-by: Wolfgang <github@linux-dude.de>

commit 38922b4
Author: Nextcloud bot <bot@nextcloud.com>
Date:   Sun May 4 01:23:25 2025 +0000

    fix(l10n): Update translations from Transifex

    Signed-off-by: Nextcloud bot <bot@nextcloud.com>

commit 2fde203
Author: Nextcloud bot <bot@nextcloud.com>
Date:   Sat May 3 01:23:52 2025 +0000

    fix(l10n): Update translations from Transifex

    Signed-off-by: Nextcloud bot <bot@nextcloud.com>

commit d621763
Author: Benjamin Brahmer <info@b-brahmer.de>
Date:   Fri May 2 11:32:53 2025 +0200

    Release 26.0.0-beta.1

    Changed
    - Drop support for Nextcloud 29 (nextcloud#3146)

    Fixed
    - respect global `disable all keyboard shortcuts` setting (nextcloud#3142)
    - disable shortcuts in input fields from global overlays (e.g. Nextcloud assistant) (nextcloud#3142)
    - fix relative date strings (nextcloud#3149)
    - Switching between folders in compact mode doesn't close actual selected item (nextcloud#3150)
    - current selected article is removed from the list after showing details in mobile mode (nextcloud#3150)

    Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>

commit dbef05f
Author: Wolfgang <github@linux-dude.de>
Date:   Thu May 1 00:16:40 2025 +0200

    fix: rework initialising virtual scroll

    Signed-off-by: Wolfgang <github@linux-dude.de>

commit 7912f6c
Author: Wolfgang <github@linux-dude.de>
Date:   Wed Apr 30 23:59:35 2025 +0200

    fix: avoid unnecessary mark read calls

    Signed-off-by: Wolfgang <github@linux-dude.de>

commit c7b998c
Author: Wolfgang <github@linux-dude.de>
Date:   Wed Apr 30 23:54:09 2025 +0200

    fix: debounce mark read on scroll function

    Signed-off-by: Wolfgang <github@linux-dude.de>

commit 493edef
Author: Wolfgang <github@linux-dude.de>
Date:   Wed Apr 30 23:30:48 2025 +0200

    fix: make seenItems non-reactive to avoid re-renders

    Signed-off-by: Wolfgang <github@linux-dude.de>

commit f0ac424
Author: Wolfgang <github@linux-dude.de>
Date:   Wed Apr 30 20:56:25 2025 +0200

    fix: clear item cache on empty routes to avoid navigating through the wrong lists

    Signed-off-by: Wolfgang <github@linux-dude.de>

commit e28dfe7
Author: Wolfgang <github@linux-dude.de>
Date:   Wed Apr 30 21:23:24 2025 +0200

    fix: move lastRendered handling to updated hook to avoid unnecessary re-renders

    Signed-off-by: Wolfgang <github@linux-dude.de>

commit 5ae564b
Author: Wolfgang <github@linux-dude.de>
Date:   Wed Apr 30 21:09:00 2025 +0200

    fix: move emit out of render function to avoid possible render loop

    Signed-off-by: Wolfgang <github@linux-dude.de>

commit 58e7dfc
Author: Nextcloud bot <bot@nextcloud.com>
Date:   Fri May 2 01:23:31 2025 +0000

    fix(l10n): Update translations from Transifex

    Signed-off-by: Nextcloud bot <bot@nextcloud.com>

commit daff426
Author: Nextcloud bot <bot@nextcloud.com>
Date:   Thu May 1 01:23:43 2025 +0000

    fix(l10n): Update translations from Transifex

    Signed-off-by: Nextcloud bot <bot@nextcloud.com>

commit b4a72e5
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Apr 30 12:41:22 2025 +0000

    build(deps): Bump @nextcloud/dialogs from 6.1.1 to 6.2.0

    Bumps [@nextcloud/dialogs](https://github.com/nextcloud-libraries/nextcloud-dialogs) from 6.1.1 to 6.2.0.
    - [Release notes](https://github.com/nextcloud-libraries/nextcloud-dialogs/releases)
    - [Changelog](https://github.com/nextcloud-libraries/nextcloud-dialogs/blob/main/CHANGELOG.md)
    - [Commits](nextcloud-libraries/nextcloud-dialogs@v6.1.1...v6.2.0)

    ---
    updated-dependencies:
    - dependency-name: "@nextcloud/dialogs"
      dependency-version: 6.2.0
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

commit 743784d
Author: Nextcloud bot <bot@nextcloud.com>
Date:   Wed Apr 30 01:24:08 2025 +0000

    fix(l10n): Update translations from Transifex

    Signed-off-by: Nextcloud bot <bot@nextcloud.com>

commit 42177c0
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Apr 29 12:23:51 2025 +0000

    build(deps): Bump fivefilters/readability.php from 3.3.2 to 3.3.3

    Bumps [fivefilters/readability.php](https://github.com/fivefilters/readability.php) from 3.3.2 to 3.3.3.
    - [Release notes](https://github.com/fivefilters/readability.php/releases)
    - [Changelog](https://github.com/fivefilters/readability.php/blob/master/CHANGELOG.md)
    - [Commits](fivefilters/readability.php@v3.3.2...v3.3.3)

    ---
    updated-dependencies:
    - dependency-name: fivefilters/readability.php
      dependency-version: 3.3.3
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

commit acf00c1
Author: Nextcloud bot <bot@nextcloud.com>
Date:   Tue Apr 29 01:23:36 2025 +0000

    fix(l10n): Update translations from Transifex

    Signed-off-by: Nextcloud bot <bot@nextcloud.com>

commit dc18ab4
Author: Wolfgang <github@linux-dude.de>
Date:   Sat Apr 26 21:49:12 2025 +0200

    fix: disable nav shortcuts when showing details in no-split-mode

    Signed-off-by: Wolfgang <github@linux-dude.de>

commit 9a987f4
Author: Wolfgang <github@linux-dude.de>
Date:   Sat Apr 26 19:42:42 2025 +0200

    fix: remove shortcut workaround, keys can now be used from parent component (upstream bug fixed in nextcloud/vue 8.26.0)

    Signed-off-by: Wolfgang <github@linux-dude.de>

commit 40a1a48
Author: Wolfgang <github@linux-dude.de>
Date:   Sat Apr 26 19:42:03 2025 +0200

    deps: update nextcloud/vue 8.26.0

    Signed-off-by: Wolfgang <github@linux-dude.de>

commit ce56212
Author: Nextcloud bot <bot@nextcloud.com>
Date:   Wed Apr 23 01:23:26 2025 +0000

    fix(l10n): Update translations from Transifex

    Signed-off-by: Nextcloud bot <bot@nextcloud.com>

commit 9f185d0
Author: Nextcloud bot <bot@nextcloud.com>
Date:   Tue Apr 22 01:23:57 2025 +0000

    fix(l10n): Update translations from Transifex

    Signed-off-by: Nextcloud bot <bot@nextcloud.com>

commit 27b575d
Author: Wolfgang <github@linux-dude.de>
Date:   Sun Apr 20 22:35:47 2025 +0200

    fix: use @nextcloud/moment for formatted date strings

    Signed-off-by: Wolfgang <github@linux-dude.de>

Signed-off-by: Juri-w <jugeorgri@gmail.com>
@wofferl wofferl deleted the fix_relative_date branch May 23, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Grotax Grotax Grotax approved these changes

Assignees

No one assigned

Labels

frontend impact Javascript/Frontend code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[UX] Incorrect use of years for 1 year old posts

2 participants

@wofferl @Grotax