Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextcloud)!: Support server 29 and spreed 19 #1894

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Apr 10, 2024

Depends on nextcloud/server#44732
This is not the final version (I hope for nextcloud/spreed#12041 to land), but everything is working already when testing against the old versions.
Once the server releases are done and the docker images are available we can also test against those and get this merged.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 9.92293% with 935 lines in your changes are missing coverage. Please review.

Project coverage is 28.02%. Comparing base (7f6a040) to head (adce63d).
Report is 4 commits behind head on main.

❗ Current head adce63d differs from pull request most recent head 1f39624. Consider uploading reports for the commit 1f39624 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1894      +/-   ##
==========================================
- Coverage   29.31%   28.02%   -1.30%     
==========================================
  Files         245      245              
  Lines       76519    81423    +4904     
==========================================
+ Hits        22430    22817     +387     
- Misses      54089    58606    +4517     
Flag Coverage Δ *Carryforward flag
dynamite 12.16% <25.00%> (-10.30%) ⬇️
dynamite_end_to_end_test 62.63% <45.94%> (-0.36%) ⬇️
dynamite_runtime 82.65% <ø> (ø)
neon_dashboard 92.56% <ø> (ø)
neon_framework 38.36% <ø> (ø)
neon_talk 96.67% <60.00%> (-0.34%) ⬇️
nextcloud 25.59% <6.41%> (-0.93%) ⬇️
sort_box 90.90% <ø> (ø) Carriedforward from e951337

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...namite/dynamite/lib/src/models/openapi/schema.dart 50.00% <ø> (-15.86%) ⬇️
...ite_end_to_end_test/lib/pattern_check.openapi.dart 90.62% <100.00%> (+3.12%) ⬆️
...te/dynamite_end_to_end_test/lib/types.openapi.dart 100.00% <100.00%> (ø)
packages/nextcloud/lib/src/api/core.openapi.dart 42.08% <ø> (-1.63%) ⬇️
packages/nextcloud/lib/src/api/core.openapi.g.dart 26.42% <ø> (-1.52%) ⬇️
...kages/nextcloud/lib/src/api/dashboard.openapi.dart 99.37% <ø> (ø)
...extcloud/lib/src/api/provisioning_api.openapi.dart 21.43% <100.00%> (ø)
packages/nextcloud/lib/src/api/spreed.openapi.dart 28.15% <ø> (-1.35%) ⬇️
...ckages/nextcloud/lib/src/api/spreed.openapi.g.dart 12.48% <ø> (+0.08%) ⬆️
...ges/nextcloud/lib/src/api/user_status.openapi.dart 82.14% <50.00%> (ø)
... and 5 more

... and 9 files with indirect coverage changes

@provokateurin
Copy link
Member Author

Everything merged upstream, this PR is ready :)

@Leptopoda
Copy link
Member

So far LGTM
I've looked at every json spec and tried to pay special attention to oneOf and anyOf. I could not find any obvious issue.

@provokateurin
Copy link
Member Author

@Leptopoda please review the maxItems fix. I think there is something fundamentally wrong about checks for types in someOfs because they don't get generated anywhere, but that was already the case before and is not in scope of this fix.

@Leptopoda Leptopoda linked an issue Apr 20, 2024 that may be closed by this pull request
@Leptopoda
Copy link
Member

I think there is something fundamentally wrong about checks for types in someOfs because they don't get generated anywhere

Can you show me where you'd expect one but they are not generated?

@provokateurin
Copy link
Member Author

@Leptopoda
Copy link
Member

I see. The only validation it uses is through the use of Never.
I think a proper validation will come once we convert someofs back to normal objects (#1508).

@provokateurin
Copy link
Member Author

Yeah, no point in spending time on fixing this right now.

@provokateurin
Copy link
Member Author

@Leptopoda can you review again?

@Leptopoda
Copy link
Member

looks good for now.
I have a lot of dynamite changes coming so I'll do a final review once it is ready to be merged

@provokateurin provokateurin marked this pull request as ready for review April 25, 2024 05:38
renovate bot and others added 5 commits April 25, 2024 05:49
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin changed the base branch from main to renovate/lock-file-maintenance April 25, 2024 05:54
Base automatically changed from renovate/lock-file-maintenance to main April 25, 2024 05:58
@provokateurin provokateurin merged commit 641715a into main Apr 25, 2024
8 checks passed
@provokateurin provokateurin deleted the feat/nextcloud/29 branch April 25, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support specified length for arrays.
2 participants