fix: listen to more out-of-office events to prevent missed changes#9095
Merged
ChristophWurst merged 1 commit intomainfrom Nov 28, 2023
Merged
fix: listen to more out-of-office events to prevent missed changes#9095ChristophWurst merged 1 commit intomainfrom
ChristophWurst merged 1 commit intomainfrom
Conversation
Member
Author
|
/backport to stable3.4 |
kesselb
approved these changes
Nov 27, 2023
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
fix/auto-responder-event-listener
branch
from
f663080 to
ee63978
Compare
ChristophWurst
approved these changes
Nov 28, 2023
Comment on lines
+72
to
+75
| $enabled = $now >= $eventData->getStartDate() && $now < $eventData->getEndDate(); | ||
| if (($event instanceof OutOfOfficeClearedEvent) || ($event instanceof OutOfOfficeEndedEvent)) { | ||
| $enabled = false; | ||
| } |
Member
There was a problem hiding this comment.
FP nit: combine into one expression
Member
Author
|
/backport to stable3.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref nextcloud/server#41778
About
OutOfOfficeStartedEventandOutOfOfficeEndedEventIn theory it is superfluous to listen for the
OutOfOfficeStartedEventandOutOfOfficeEndedEventevents. However, I opted to keep listening for them and only really "enable" the sieve script when the out-of-office period is ongoing.Please also refer to my lengthy comment in the code.