Skip to content

Cache provisioning configs #6325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2022
Merged

Cache provisioning configs #6325

merged 1 commit into from
May 12, 2022

Conversation

@miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Apr 27, 2022

Fixes #4983

@miaulalala miaulalala added this to the v1.12.0 milestone Apr 27, 2022
@miaulalala miaulalala self-assigned this Apr 27, 2022
@ChristophWurst
Copy link
Member

ChristophWurst commented Apr 28, 2022

Does this actually work?

  1. ICache is not injectable. You have to use the factory to acquire a local or distributed cache
  2. ICache::get gives you a string, not an array of deserialized objects

@ChristophWurst ChristophWurst marked this pull request as draft April 28, 2022 09:50
@miaulalala miaulalala marked this pull request as ready for review April 28, 2022 17:15
@ChristophWurst ChristophWurst force-pushed the enhancement/cache-provisionings branch from b07255e to 304e2aa Compare April 29, 2022 13:46
ChristophWurst
ChristophWurst approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, reviewed and profiled

Bildschirmfoto vom 2022-04-29 15-44-10
Bildschirmfoto vom 2022-04-29 15-44-56

@ChristophWurst ChristophWurst modified the milestones: v1.12.0, v1.13.0 May 2, 2022
@ChristophWurst
Copy link
Member

ChristophWurst commented May 5, 2022

@miaulalala please make your code compatible with PHP7.3. We will migrate the code to PHP7.4 once 7.3 is gone

@ChristophWurst ChristophWurst force-pushed the enhancement/cache-provisionings branch from 304e2aa to d85ec1f Compare May 12, 2022 14:01
@miaulalala
Cache provisioning configs
aae3d72 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the enhancement/cache-provisionings branch from d85ec1f to aae3d72 Compare May 12, 2022 14:36
@miaulalala miaulalala enabled auto-merge May 12, 2022 14:37
@miaulalala miaulalala merged commit b2e9746 into main May 12, 2022
@miaulalala miaulalala deleted the enhancement/cache-provisionings branch May 12, 2022 15:25
@ChristophWurst ChristophWurst mentioned this pull request Feb 8, 2023
Merged
@ChristophWurst ChristophWurst mentioned this pull request Feb 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees

@miaulalala miaulalala

Labels

4. to release enhancement performance 🚀

Projects

None yet

Milestone

v1.13.0

Development

Successfully merging this pull request may close these issues.

Cache provisioning configs

3 participants

@miaulalala @ChristophWurst