Skip to content

Conversation

@miaulalala
Copy link
Contributor

Add indices on mail_messages table

change column types to bigint for tables recipients and messages

Change foreign keys to named foreign keys for recipients and attachments

Fixes #4466
Fixes #5985
Fixes #4664
Fixes #6223

@miaulalala miaulalala force-pushed the enhancement/performance-improvements branch from 29f1721 to 873e34a Compare April 20, 2022 19:37
@miaulalala
Copy link
Contributor Author

/backport to stable1.12

@miaulalala miaulalala force-pushed the enhancement/performance-improvements branch from 873e34a to a2a4c05 Compare April 22, 2022 12:33
@miaulalala miaulalala requested review from CarlSchwan and blizzz April 22, 2022 12:52
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works

@miaulalala miaulalala force-pushed the enhancement/performance-improvements branch from a2a4c05 to e2db9cf Compare April 27, 2022 21:06
@ChristophWurst
Copy link
Member

info.xml bump missing

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

On my test instance there are no improvements to measure with blackfire.io. It's on par with the unoptimized version.

Bildschirmfoto vom 2022-04-29 16-15-47

@ChristophWurst
Copy link
Member

ChristophWurst commented May 4, 2022

@miaulalala could you bump info.xml, rename the migration and rebase to latest main?

change columnst to bigint, create named foreign keys

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the enhancement/performance-improvements branch from e2db9cf to f381db7 Compare May 12, 2022 14:32
@miaulalala miaulalala requested a review from ChristophWurst May 12, 2022 14:32
@kesselb
Copy link
Contributor

kesselb commented May 13, 2022

@miaulalala can we close #5294 too?

@miaulalala
Copy link
Contributor Author

Yep, that should be fine to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

7 participants