Normalize envelope tags in vuex store #4902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
force-pushed
the
enhancement/4871/normalize-tags-in-vuex
branch
2 times, most recently
from
96d740a to
c67a1b3
Compare
ChristophWurst
approved these changes
Apr 9, 2021
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
ChristophWurst
force-pushed
the
enhancement/4871/normalize-tags-in-vuex
branch
from
f1e1509 to
d4e4817
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4871
Move envelope tags to global object and index them by their id. Every envelope will store an array of tag ids in
envelope.tags.Get all tag objects of an envelope via
$store.getters.getEnvelopeTags(envelope.databaseId)Add a tag to an envelope via
$store.dispatch('addEnvelopeTag', { envelope, imapLabel })Remove a tag from an envelope via
$store.dispatch('removeEnvelopeTag', { envelope, tag })Get a tag from the global store via
$store.getters.getTag(tagId)This PR will also fix the important toggles.