Skip to content

Add UI for tag assignment #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2021
Merged

Add UI for tag assignment #4829

merged 1 commit into from
May 28, 2021

Conversation

@GretaD
Copy link
Contributor

@GretaD GretaD commented Mar 25, 2021 •
edited
Loading

Fixes #4807

  • Add a tag
  • Remove a tag
  • Polish

@GretaD GretaD self-assigned this Mar 25, 2021
@ChristophWurst ChristophWurst changed the title Tagging UI Add UI for tag assignment Mar 25, 2021
@ChristophWurst ChristophWurst added this to the v1.10.0 milestone Mar 25, 2021
@GretaD GretaD force-pushed the enhancenment/tagging_UI branch from 07acac6 to a6800cb Compare May 18, 2021 15:32
@ChristophWurst
Copy link
Member

@GretaD what is the progress here? Could you please add a todo list or something to the PR description? :)

@GretaD GretaD force-pushed the enhancenment/tagging_UI branch 3 times, most recently from b34b645 to adcc483 Compare May 26, 2021 17:11
ChristophWurst
ChristophWurst requested changes May 26, 2021
View reviewed changes
@ChristophWurst ChristophWurst mentioned this pull request May 26, 2021
Merged
@marcoambrosini
Copy link
Member

Oops wrong pr 🤦‍♂️

@GretaD GretaD requested a review from marcoambrosini May 27, 2021 14:12
@GretaD
Copy link
Contributor Author

GretaD commented May 27, 2021

Oops wrong pr

haha, and since you're here, have a look :D

@ChristophWurst ChristophWurst force-pushed the enhancenment/tagging_UI branch 2 times, most recently from f284a54 to 1fea95a Compare May 28, 2021 06:31
@ChristophWurst ChristophWurst mentioned this pull request May 28, 2021
Closed
ChristophWurst
ChristophWurst requested changes May 28, 2021
View reviewed changes
@ChristophWurst ChristophWurst marked this pull request as ready for review May 28, 2021 06:49
@ChristophWurst ChristophWurst force-pushed the enhancenment/tagging_UI branch from a53353d to 5a653ac Compare May 28, 2021 07:03
@GretaD GretaD mentioned this pull request May 28, 2021
Closed
@GretaD GretaD requested a review from ChristophWurst May 28, 2021 07:39
ChristophWurst
ChristophWurst approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@GretaD @ChristophWurst
Tagging UI
969b1c7 
Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: GretaD <gretadoci@gmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the enhancenment/tagging_UI branch from 5a653ac to 969b1c7 Compare May 28, 2021 09:40
@ChristophWurst ChristophWurst merged commit 807b1eb into master May 28, 2021
@ChristophWurst ChristophWurst deleted the enhancenment/tagging_UI branch May 28, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@GretaD GretaD

Labels

4. to release enhancement feature parity

Projects

None yet

Milestone

v1.10.0

Development

Successfully merging this pull request may close these issues.

Add UI to assign tags

4 participants

@GretaD @ChristophWurst @marcoambrosini