Skip to content

Improve design of account settings, move signature and writing mode up #2119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2019
Merged

Improve design of account settings, move signature and writing mode up #2119

merged 1 commit into from
Oct 17, 2019

Conversation

@jancborchardt
Copy link
Member

Before

  • Nerdy IMAP and SMTP settings up top so the other stuff was not findable
  • Didn’t seem to have structure, stuff too close together
  • Elements too small (textarea) or wrong element (dropdown for choice between 2)

image
image

After

  • Moved signature and writing mode up so it’s easier to discover
  • Proper structure with headings
  • Detail fixes and interaction feedback
    image

Please review @nextcloud/mail :)

@jancborchardt jancborchardt added this to the next milestone Oct 16, 2019
@skjnldsv skjnldsv mentioned this pull request Oct 16, 2019
Closed
19 tasks
@jancborchardt jancborchardt force-pushed the design/settings branch 2 times, most recently from 50164fd to 586c6bc Compare October 16, 2019 21:25
@jancborchardt jancborchardt mentioned this pull request Oct 17, 2019
Closed
3 tasks
@jancborchardt
Improve design of account settings, move signature and writing mode up
246c686 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
kevgathuku
kevgathuku approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@kevgathuku kevgathuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better 👍

@ChristophWurst ChristophWurst merged commit 62d4b99 into master Oct 17, 2019
@ChristophWurst ChristophWurst deleted the design/settings branch October 17, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevgathuku kevgathuku kevgathuku approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Gomez Gomez Awaiting requested review from Gomez

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to review design enhancement

Projects

None yet

Milestone

0.18.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jancborchardt @kevgathuku @skjnldsv @ChristophWurst