-
Couldn't load subscription status.
- Fork 287
enh: redesign email display on phones #11754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
enh: redesign email display on phones #11754
Conversation
Added a few changes such as the email content will now take the phone's screen full width, the topbar will partly hide itself on scroll, removed blank space under email, ... Signed-off-by: Tobiáš Vašťák <johnsonpe83@gmail.com>
Align skeleton loading to left for phones < 500px screen width Signed-off-by: Tobiáš Vašťák <johnsonpe83@gmail.com>
Make the phishing suspicion warning be aligned well with the rest of the content Signed-off-by: Tobiáš Vašťák <johnsonpe83@gmail.com>
|
What do you think @nimishavijay ? Any suggestions or ideas? |
|
Looks really nice! :) thanks for cleaning up the sticky header and the bottom spaces in addition. I see that right now the participants are sticky while I think it would make more sense of the title is sticky, don't you think? So I would suggest some small changes:
|
|
Okay, sure, makes sense to me :) So on scroll, it will display the first line of the subject and the parcipiants below, like it does when not scrolling. Then I have to fix the issue with unsubscribe button overlapping actions menu and that should be all |
|
And also... could this PR contain something like this? I think it looks better, what's your opinion on this @nimishavijay
|
8b0c5a7 to
470e39d
Compare
Make the email content full screen wide, when screen < 600 px. And a few other fixes Signed-off-by: Tobiáš Vašťák <johnsonpe83@gmail.com>
470e39d to
e1a3956
Compare
Fixes width of an event div, so it matches rest of the content. Signed-off-by: Tobiáš Vašťák <johnsonpe83@gmail.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Update: I'll get back to this as soon as I can. Only the unsub button is remaing. I will post how it looks, hopefully, later today. |
Show only one line of the email subject. Signed-off-by: Tobiáš Vašťák <johnsonpe83@gmail.com>
|
I made a few changes and now it looks like: progress_update.mp4The animation can be a bit buggy, I'll try to fix that next time. |
|
Awesome! Looks really nice :) Regarding the unsubscribe button, it's definitely an improvement. It would be difficult to make sure that an email address of any length is shown fully if we want to keep the unsubscribe button on the same row, so I would say we should either
Since there are already many elements between the sender details and the body (phishing warning, show images warning, etc) I would vote for clicking on the sender to see the full email address (similar to what Gmail does in mobile). The unsubscribe fix can be done in a follow up btw! This is a great place to wrap up this PR design wise :) |


Fixes #11663
This is a draft PR - I need to get feedback from @nimishavijay
Changes
Notes
Before
Mail.-.Nextcloud.-.Google.Chrome.2025-09-27.00-29-49.mp4
What I've done so far
Mail.-.Nextcloud.-.Google.Chrome.2025-09-27.00-31-36.mp4