enforce dangling comma / update jsdoc for getSubnameForRecipient #11266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
force-pushed
the
docs/missing-jsdoc-warning-forsubname
branch
from
c4adecc to
17417fc
Compare
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
The ESLint comma-dangle rule issues warnings but doesn't fail the CI. Running npm run lint:fix adds missing commas automatically. This often leads to committing unrelated changes. Now, the CI enforces the dangling comma rule. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
docs/missing-jsdoc-warning-forsubname
branch
from
17417fc to
79970b2
Compare
ChristophWurst
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ESLint comma-dangle rule issues warnings but doesn't fail the CI. Running npm run lint:fix adds missing commas automatically. This often leads to committing unrelated changes. Now, the CI enforces the dangling comma rule.