fix: LogIterator duplicates and drops log entries

[jmechnich]

Fixes #1236.

[jmechnich]

This conditional here

logreader/lib/Log/LogIterator.php

Lines 93 to 97 in 0a97cbc

	if ($newlinePos+1 === strlen($this->buffer)) {
	// try again with truncated buffer if it ends with newline, i.e. on first call
	$this->buffer = substr($this->buffer, 0, $newlinePos);
	continue;
	}

could possibly be replaced by just seeking one byte before EOF to cut off the final newline:
In LogIterator::rewind(): fseek($this->handle, -1, SEEK_END);

Not sure how reliable this assumption is though.

[icewind1991]

Added some changes to make the tests pass, please verify that things are still working as expected for you.

could possibly be replaced by just seeking one byte before EOF to cut off the final newline:
In LogIterator::rewind(): fseek($this->handle, -1, SEEK_END);

I think the current approach is more reliable

[jmechnich]

Added some changes to make the tests pass, please verify that things are still working as expected for you.

Looks good, thanks! 👍

[icewind1991]

/backport to stable29

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!