fix #959: normalize switch statement case#1155
Open
karlbeecken wants to merge 1 commit intonextcloud:mainfrom
Open
fix #959: normalize switch statement case#1155karlbeecken wants to merge 1 commit intonextcloud:mainfrom
karlbeecken wants to merge 1 commit intonextcloud:mainfrom
Conversation
Signed-off-by: Karl Beecken <karl@beecken.berlin>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is essentially the fix proposed in #959 (comment).
The two switch statements in
LDAPGroupManager.phpare changed to use strtolower so that the matching will be case-insensitive to fix the issue arising in combination with Nextcloud>=31, that leads to admins not being able to add/remove LDAP groups to users.I tested this on my instance with Nextcloud Hub 32.0.3, it works perfect.