Skip to content

Universal write support #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 50 commits into from
Jun 27, 2019
Merged

Universal write support #1

merged 50 commits into from
Jun 27, 2019

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Jun 17, 2019 •
edited
Loading

blizzz added 13 commits May 22, 2019 22:40
@blizzz
adapt info and give its own name
e6020d2 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
remove some not needed components
70bbbb2 
- install script only logged a message
- Controllers were not used and also unrelated

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
convert app init script to Application
c9b04ec 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
namespace adjustments
1b30bc1 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
keep LDAPConnect working like this for now…
6a1b379 
needs changes in LDAPProvider

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
fix initialisation for now, add LDAPUserManager dep on LDAP provider
8a5fbb0 
nicer fix needs changes in server

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
conditionally, use actor's LDAP connection and prevent fallback to local
7481f16 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
Use and LDIF as user creation template
1587f5d 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
User LDIF Template Editor WebUI
dd2795e 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
register hooks on app load
871f6b7 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
add displayname to default template
57e3b37 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
remove duplicate entry
6a2f094 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
add DI and clean uo setDisplayNameRoutine
fec2fa2 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the universal-write-support branch from a460d38 to fec2fa2 Compare June 17, 2019 22:16
blizzz added 16 commits June 18, 2019 13:02
@blizzz
makes us of proper deletion process of the LDAP user
594dd32 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
method signatures for changing details and email
8b10c7e 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
updates phpdoc
5bb1d08 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
uses API method to flag LDAP user as deleted
4fc1785 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
formatting and cleanup
5c4701e 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
removes uid generation as this will be done by provisioning API
386f5da 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
removes unnecessary construct argument
3cf9151 
* also renames another member var

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
resolves IConfig dependency on LDAPUserManager
f705241 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
adds UI for switches
ca39d03 
* createPreventFallback
* createRequireActorFromLdap

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
adds UI switches for newUser.requireEmail and newUser.generateUserID
7fd173e 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
adds Avatar switch
5aaddbb 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
polishes classes:
900c655 
* no duplicate functions for adding/removing users to groups
* remove unused class
* formatting and PhpDoc
* uniqueMember attribute support added

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
removes unneeded log statements
7b98187 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
fetches first LDAP configuration prefix instead of guessing
774a099 
* works then with the Configuration instead of reading from IConfig
* disconnect() was unused, and happens automatically when script ends

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
inserts ILogger dep
e176c08 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
sanitizes the DN before creating the user, so the further process suc…
f976df0 
…ceeds

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the universal-write-support branch 2 times, most recently from ba313a2 to 9afda69 Compare June 20, 2019 21:34
blizzz added 2 commits June 20, 2019 23:40
@blizzz
resolves dependency hell, all traits are already inherited
0b51150 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
fixed default template, an extinct placeholder was used
e9b0ab3 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the universal-write-support branch from 9afda69 to e9b0ab3 Compare June 20, 2019 21:42
@blizzz
sets user base
8acbc41 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the universal-write-support branch from 6310f71 to 8acbc41 Compare June 20, 2019 21:56
blizzz added 7 commits June 21, 2019 00:03
@blizzz
fixes conversion issue, an array is returned here of course
66b02ee 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
removes unnecessary objectclass from default template
6809496 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
fixes lookup being not key insensitive
b0da046 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
fixes expected status code
43f8ed0 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
adjusts to server config switch changes
4338fed 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
add test for dynamic user id and thus run against master
a21af4f 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
extend tests with displayname
25b8c55 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the universal-write-support branch from 2f1ca98 to c608db0 Compare June 25, 2019 21:58
@blizzz
also run tests without a cache
a92ceda 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the universal-write-support branch from c608db0 to a92ceda Compare June 26, 2019 06:27
blizzz added 2 commits June 26, 2019 12:10
@blizzz
fix deletion of users (figured without redis)
9bd731d 
require a server/user_ldap PR for proper cleanup

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
uses the user deletion method that deletes the user just once...
0660d97 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz mentioned this pull request Jun 26, 2019
Merged
@blizzz
add test for creating group and creating a new user with that membership
f9e2464 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz marked this pull request as ready for review June 27, 2019 09:18
@blizzz blizzz requested review from rullzer and viniciuscb June 27, 2019 09:18
@blizzz
Copy link
Member Author

blizzz commented Jun 27, 2019

That's ready for review

I'll add screenshots, README, and deployment bits later

rullzer
rullzer approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzz blizzz merged commit 1bcb819 into master Jun 27, 2019
@blizzz blizzz deleted the universal-write-support branch June 27, 2019 11:28
@joergmschulz joergmschulz mentioned this pull request Jul 12, 2019
Closed
@kousu kousu mentioned this pull request May 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@viniciuscb viniciuscb Awaiting requested review from viniciuscb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz @rullzer