fix: set address book as not local #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
force-pushed
the
fix/noid/address-book-not-local
branch
from
b06ec0a to
c5227b3
Compare
ArtificialOwl
force-pushed
the
fix/noid/address-book-not-local
branch
2 times, most recently
from
076b711 to
ef44264
Compare
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/noid/address-book-not-local
branch
from
ef44264 to
0ed7867
Compare
come-nc
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if set as local system address book, a userId is expected in some place on code (ie. https://github.com/nextcloud/server/blob/b15fdfd40e4bf96b53f7afcf0e4dce359158cf1c/lib/private/Contacts/ContactsMenu/ContactsStore.php#L210)
the main issue appears when sharing to one of the contacts while limiting shares to accounts belonging to same groups:
https://github.com/nextcloud/server/blob/77194d5232bd3e27758d7b20145c43e13e180594/lib/private/Collaboration/Collaborators/MailPlugin.php#L114-L134
note
Backports will need to check version from core (
> 32.0.3,> 31.0.12) inlib/Service/ContactsAddressBook.php