Skip to content

Use IExternalProvider in search provider #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 1, 2025
Merged

Use IExternalProvider in search provider #137

merged 6 commits into from
Oct 1, 2025

Conversation

@julien-nc
Copy link
Member

@julien-nc julien-nc commented Sep 29, 2025 •
edited
Loading

  • update composer dependencies
  • use psalm 6 and fix psalm issues
  • support NC >= 32

@julien-nc julien-nc force-pushed the enh/noid/search-external-provider branch from 37e30cb to 416d73b Compare September 29, 2025 10:39
@julien-nc
Copy link
Member Author

julien-nc commented Sep 29, 2025 •
edited
Loading

No idea about the missing oc_external_mounts in the Phpunit tests.

It seems it appeared with 32: https://github.com/nextcloud/integration_github/actions/runs/18067163489/job/51411497954

@kyteinsky
Copy link
Contributor

Caused by
PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'nextcloud.oc_external_mounts' doesn't exist

/home/runner/work/integration_github/integration_github/3rdparty/doctrine/dbal/src/Driver/PDO/Statement.php:130
/home/runner/work/integration_github/integration_github/3rdparty/doctrine/dbal/src/Connection.php:1104
/home/runner/work/integration_github/integration_github/lib/private/DB/Connection.php:420
/home/runner/work/integration_github/integration_github/lib/private/DB/ConnectionAdapter.php:50
/home/runner/work/integration_github/integration_github/lib/private/DB/QueryBuilder/QueryBuilder.php:291
/home/runner/work/integration_github/integration_github/apps/files_external/lib/Service/DBConfigService.php:379
/home/runner/work/integration_github/integration_github/apps/files_external/lib/Service/DBConfigService.php:79
/home/runner/work/integration_github/integration_github/apps/files_external/lib/Service/UserGlobalStoragesService.php:174
/home/runner/work/integration_github/integration_github/apps/files_external/lib/Config/ConfigAdapter.php:104
/home/runner/work/integration_github/integration_github/lib/private/Files/Config/MountProviderCollection.php:56
/home/runner/work/integration_github/integration_github/lib/private/Files/Config/MountProviderCollection.php:113
/home/runner/work/integration_github/integration_github/lib/private/Files/SetupManager.php:205
/home/runner/work/integration_github/integration_github/lib/private/Files/SetupManager.php:316
/home/runner/work/integration_github/integration_github/lib/private/Files/SetupManager.php:204
/home/runner/work/integration_github/integration_github/lib/private/legacy/OC_Util.php:49
/home/runner/work/integration_github/integration_github/tests/lib/TestCase.php:467
/home/runner/work/integration_github/integration_github/apps/integration_github/tests/unit/Controller/GithubAPIControllerTest.php:49

seems like it directly comes from files_external app doing something funny on the $this->loginAsUser(self::TEST_USER1); call:

integration_github/tests/unit/Controller/GithubAPIControllerTest.php

Line 49 in 5ca261a

$this->loginAsUser(self::TEST_USER1);

can be ignored I think, and maybe reported.

kyteinsky
kyteinsky reviewed Sep 29, 2025
View reviewed changes
tests/bootstrap.php Outdated
require_once __DIR__ . '/../../../tests/bootstrap.php';

\OC_App::loadApps();
\OC::$server->get(IAppManager::class)->loadApp(Application::APP_ID);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
\OC::$server->get(IAppManager::class)->loadApp(Application::APP_ID);
\OCP\Server::get(IAppManager::class)->loadApp(Application::APP_ID);

nit

@julien-nc julien-nc force-pushed the enh/noid/search-external-provider branch 3 times, most recently from 5c42e26 to a072538 Compare October 1, 2025 08:35
@julien-nc
chore: use IExternalProvider, update composer dependencies, use psalm…
757eaf2 
… 6, fix psalm issues

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
run cs:fix
baf4bcd 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
fix composer platform overrides
e4163c2 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
adjust bootstrap
69a016e 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
attempt to fix tests
bcc3e99 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
lower the php version dependency to 8.1
1fd19c9 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the enh/noid/search-external-provider branch 3 times, most recently from e3e0faf to 1fd19c9 Compare October 1, 2025 09:04
@julien-nc julien-nc merged commit 510c3fc into main Oct 1, 2025
41 of 59 checks passed
@julien-nc julien-nc deleted the enh/noid/search-external-provider branch October 1, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyteinsky kyteinsky kyteinsky left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@julien-nc @kyteinsky