Allow to set a personal token even if oauth is possible #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyteinsky
reviewed
Nov 5, 2024
src/components/PersonalSettings.vue
Outdated
| </div> | ||
| <NcButton v-if="!connected" | ||
| <NcButton v-if="showOAuth && !connected" | ||
| :disabled="loading === true || (!showOAuth && !state.token)" |
There was a problem hiding this comment.
loading === true || !!state.token"
since false showOAuth would hide the element, and a populated token field should disable this btn
There was a problem hiding this comment.
Yup. Since there are 2 buttons now, the oauth one should be disabled if the token is defined. If that's what you mean, done.
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/allow-oauth-or-personal-token
branch
from
690bbae to
3795b59
Compare
kyteinsky
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it cannot hurt.