Add password confirmation #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
kyteinsky
reviewed
Oct 16, 2024
| if (in_array($key, ['client_id', 'client_secret', 'default_link_token'], true)) { | ||
| $this->secretService->setEncryptedAppValue($key, $value); | ||
| } else { | ||
| $this->config->setAppValue(Application::APP_ID, $key, $value); |
There was a problem hiding this comment.
let's throw a bad request response here
There was a problem hiding this comment.
in the else block since this function should only serve to sensitive values. It would be cleaner but is fine either way.
There was a problem hiding this comment.
It's fine to set any value with this setSensitiveAdminConfig endpoint.
We just want to prevent using wrong keys in the setAdminConfig endpoint.
kyteinsky
reviewed
Oct 16, 2024
kyteinsky
approved these changes
Oct 16, 2024
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for sensitive admin settings and fix mistake: saving dummy values in admin settings.