fix(downloadFile): write directly to file using Guzzle's "sink" option #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR transitions our file download logic from using Guzzle's stream => true option to the more memory-efficient sink option, mirroring improvements made in other integrations (e.g., OneDrive Integration).
While
stream => trueprevents Guzzle from buffering the entire response body in memory upfront, it returns aPsr\Http\Message\StreamInterface. When we iteratively read from this stream (e.g., withfread()), each chunk is copied into a PHP string variable before being written to disk. This creates temporary data duplication in PHP's userland memory for each chunk.Furthermore, even with
stream => true, data passes through various buffering layers:These, combined with the chunk copied into our PHP variable, contribute to memory pressure during large file downloads, potentially leading to memory_limit issues.
The Guzzle sink option provides a more direct path. Guzzle streams the HTTP response body directly into the provided writable resource (e.g., a file handle) which significantly reduces memory overhead.