Skip to content

Try to return the owner of the mountpoint before returning no owner#797

Merged
juliusknorr merged 1 commit intomasterfrom
bugfix/noid/return-the-owner-of-the-mountpoint-instead-of-noone
Apr 2, 2020
Merged

Try to return the owner of the mountpoint before returning no owner#797
juliusknorr merged 1 commit intomasterfrom
bugfix/noid/return-the-owner-of-the-mountpoint-instead-of-noone

Conversation

@nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test but looks good

@ChrisanthLederer
Copy link

ChrisanthLederer commented Mar 23, 2020

Hi rullzer,
I have manually applied the changes to my Nextcloud 18.0.2 installation.
This fixes the upload error, but no upload activity is logged and notification email is generated :-(

Now the big problem is that you are not able to delete files that have been uploaded
by an external user (that has been send a folder link).
A Fatal webdav OCP\Files\NotFoundException: CLOUD/10000/test.pdf has no owner
is raised in /var/www/nextcloud/lib/private/Files/Filesystem.php - line 907
after I changed View.php to throw a NotFoundException (#19978).

Regards
Chris

@mesiah1970-haydar
Copy link

Hi rullzer,
I have manually applied the changes to my Nextcloud 18.0.2 installation.
This fixes the upload error, but no upload activity is logged and notification email is generated :-(

Now the big problem is that you are not able to delete files that have been uploaded
by an external user (that has been send a folder link).
A Fatal webdav OCP\Files\NotFoundException: CLOUD/10000/test.pdf has no owner
is raised in /var/www/nextcloud/lib/private/Files/Filesystem.php - line 907
after I changed View.php to throw a NotFoundException (#19978).

Regards
Chris

Hello Chris I just can confirm this: Error, while deleting file.
But the upload error was gone, after I've deactivated the activity app. So I can live without the activity log, but not with error deleting the file

@juliusknorr
Copy link
Member

@ChrisanthLederer The error is not related to this PR but to nextcloud/server#19978 as that also requires nextcloud/activity#436 for activity then.

Also regarding activities in groupfolders see nextcloud/activity#190

@juliusknorr juliusknorr merged commit 943bd3d into master Apr 2, 2020
@juliusknorr juliusknorr deleted the bugfix/noid/return-the-owner-of-the-mountpoint-instead-of-noone branch April 2, 2020 15:00
@juliusknorr
Copy link
Member

/backport to stable5

@juliusknorr
Copy link
Member

/backport to stable4

@backportbot-nextcloud
Copy link

backport to stable5 in #852

@backportbot-nextcloud
Copy link

backport to stable4 in #853

@mesiah1970-haydar
Copy link

/backport to stable4

Hello Julius,

ist this related to the issue of

ChrisanthLederer commented 14 days ago •

in this conversation??

Haydar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Items that need to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants