Skip to content

feat: implement automatic creation of .system folder in auto-created team-folder - #5011

Open
Fin-c wants to merge 1 commit into
nextcloud:masterfrom
Dataport:feature/generate_automatic_appdata_Folder
Open

feat: implement automatic creation of .system folder in auto-created team-folder#5011
Fin-c wants to merge 1 commit into
nextcloud:masterfrom
Dataport:feature/generate_automatic_appdata_Folder

Conversation

@Fin-c

@Fin-c Fin-c commented Aug 10, 2026

Copy link
Copy Markdown

feat: create an .system folder in the team-folder after creating a team. This hidden folder will hold team-owned app-data in the future.

Relates to nextcloud/circles#2637

πŸ€– AI (if applicable)

  • The content of this PR was

@Fin-c
Fin-c force-pushed the feature/generate_automatic_appdata_Folder branch 2 times, most recently from 900b89d to b91c146 Compare August 11, 2026 08:59
@Fin-c Fin-c changed the title feat: implement automatic creation of .apps folder in team spaces feat: implement automatic creation of .systems folder in team spaces Aug 11, 2026
@alimmroth alimmroth changed the title feat: implement automatic creation of .systems folder in team spaces feat: implement automatic creation of .system folder in auto-created team-folder Aug 11, 2026
@alimmroth alimmroth moved this from Backlog to In review in πŸ‘₯ Teams Aug 11, 2026
@alimmroth alimmroth linked an issue Aug 11, 2026 that may be closed by this pull request
Comment thread lib/TeamSpace/TeamSpaceService.php Outdated
Comment thread lib/TeamSpace/TeamSpaceService.php Outdated
@Fin-c
Fin-c force-pushed the feature/generate_automatic_appdata_Folder branch from b91c146 to 9b6e413 Compare August 12, 2026 11:45
@Fin-c
Fin-c requested a review from mejo- August 17, 2026 13:54
@Fin-c
Fin-c force-pushed the feature/generate_automatic_appdata_Folder branch from 9b6e413 to c55a419 Compare August 17, 2026 14:11
@susnux

susnux commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Keep this in mind: nextcloud/server#46309

Meaning that folder must not have team specific contents in root level but should be considered to also contain other apps data to not create more folders like this in the future.

Comment thread lib/TeamSpace/TeamSpaceService.php Outdated
Comment thread lib/TeamSpace/TeamSpaceService.php Outdated
*
* @throws \RuntimeException when the directory cannot be created.
*/
private function ensureAppDirectory(IStorage $storage, string $path): void {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this ever be used outside of createAppDirectory? If not, maybe we should merge both functions.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think not. we can merge

@tomek2k1 tomek2k1 added the 3. to review Items that need to be reviewed label Aug 21, 2026
Co-authored-by: Copilot <copilot@github.com> Assisted-by: GPT-5.3 Codex

Signed-off-by: Fin Clausen <Fin.Clausen@dataport.de>
@Fin-c
Fin-c force-pushed the feature/generate_automatic_appdata_Folder branch from c55a419 to ef97748 Compare August 21, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Items that need to be reviewed

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Store all team-related app-data in a team-folder

6 participants