fix(dav): Register DAV plugins via SabrePluginAddEvent #4234
+116
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtrichards
force-pushed
the
jtr/dav-plugins-event-reg
branch
from
ebfa193 to
daa6ca6
Compare
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Replaced with event listeners Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
jtr/dav-plugins-event-reg
branch
from
08141d3 to
d156e21
Compare
joshtrichards
changed the title
joshtrichards
added
3. to review
joshtrichards
requested review from
artonge,
come-nc and
icewind1991
as code owners
come-nc
reviewed
Jan 6, 2026
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
I’m afraid about this because there are code paths which loads plugins from PluginManager::getAppPlugins which are not triggering SabrePluginAddEvent.
Also there is the ServerFactory using OCP\SabrePluginEvent 🤷
So I’d favor a cleanup of sabre server building on server side before migrating applications, unless you’re sure the plugins from groupfolders are only needed in the code paths using SabrePluginAddEvent ?
icewind1991
reviewed
Jan 9, 2026
Comment on lines
+41
to
+42
| # php-version: ${{ steps.versions.outputs.php-available }} | ||
| php-version: '8.2' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactor that modernizes slightly, by switching SabreDAV plugin loading over to the event listener. Drops Sabre plugin management declarations from
appinfo/info.xml.Doesn't make any real difference at the moment, but less future code debt.
Misc:
TODO:
Split out Psalm php version range temporary lock into separate PRDrop Psalm php version lock once split out is merged