fix: numbers and underscore are not sorted correctly #4096
Conversation
leftybournes
force-pushed
the
leftybournes/fix/sorting
branch
from
61560a1 to
ad65e30
Compare
salmart-dev
left a comment
salmart-dev
left a comment
There was a problem hiding this comment.
Tested and the current fix works. I added another comment for an optimization to avoid scanning the names of folders up to 8 times just to find out if they have an _ at the beginning or not.
leftybournes
force-pushed
the
leftybournes/fix/sorting
branch
from
ad65e30 to
318bc21
Compare
|
Should have seen it coming, you need to update the cypress version about files_versions. You can copy past what I did in https://github.com/nextcloud/server/pull/55965/files#diff-2624570d4890032e1950b55bc6ab8d8e4bbc2e5d9f86f200254e05c7d64863a5 |
Thank you for the help. Here's the PR that does the same. There's progress but it's still failing. |
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Could you move this logic to a dedicated method, so it's not duplicated? This calls for further issues down the line
Signed-off-by: Kent Delante <kent.delante@proton.me>
leftybournes
force-pushed
the
leftybournes/fix/sorting
branch
from
318bc21 to
502050b
Compare
|
/backport to stable32 |
|
/backport to stable31 |
This fixes the issue of team folders not being sorted properly when there are more than one page of folders (>50 folders), especially when a folder name starts with an underscore. When a folder name starts with an underscore, it disappears until the last page is revealed and then suddenly appears in the first page. This also naturally sorts folder names with numbers.