Groupfolder 20.1.0 migration fails and leaves instances in an unusable state

[nursoda]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

Steps to reproduce

1. Update groupfolders from 20.0.1 to 20.1.0

Actual behaviour

occ app:update --all

groupfolders new version available: 20.1.0
An unhandled exception has been thrown:
ArgumentCountError: Too few arguments to function OCA\GroupFolders\Folder\FolderDefinition::__construct(), 6 passed in PATH/apps/groupfolders/lib/Folder/FolderManager.php on line 552 and exactly 7 expected in PATH/apps/groupfolders/lib/Folder/FolderDefinition.php:12
Stack trace:
#0 PATH/apps/groupfolders/lib/Folder/FolderManager.php(552): OCA\GroupFolders\Folder\FolderDefinition->__construct()
#1 PATH/apps/groupfolders/lib/Folder/FolderManager.php(87): OCA\GroupFolders\Folder\FolderManager->rowToFolder()
#2 PATH/apps/groupfolders/lib/Migration/WrongDefaultQuotaRepairStep.php(32): OCA\GroupFolders\Folder\FolderManager->getAllFolders()
#3 PATH/lib/private/Repair.php(107): OCA\GroupFolders\Migration\WrongDefaultQuotaRepairStep->run()
#4 PATH/lib/private/legacy/OC_App.php(574): OC\Repair->run()
#5 PATH/lib/private/App/AppManager.php(1059): OC_App::executeRepairSteps()
#6 PATH/lib/private/Installer.php(111): OC\App\AppManager->upgradeApp()
#7 PATH/core/Command/App/Update.php(88): OC\Installer->updateAppstoreApp()
#8 PATH/3rdparty/symfony/console/Command/Command.php(326): OC\Core\Command\App\Update->execute()
#9 PATH/3rdparty/symfony/console/Application.php(1078): Symfony\Component\Console\Command\Command->run()
#10 PATH/3rdparty/symfony/console/Application.php(324): Symfony\Component\Console\Application->doRunCommand()
#11 PATH/3rdparty/symfony/console/Application.php(175): Symfony\Component\Console\Application->doRun()
#12 PATH/lib/private/Console/Application.php(187): Symfony\Component\Console\Application->run()
#13 PATH/console.php(90): OC\Console\Application->run()
#14 PATH/occ(33): require_once('...')
#15 {main}Setting log level to debug

occ maintenance:mode --off
occ upgrade

An unhandled exception has been thrown:
TypeError: json_decode(): Argument #1 ($json) must be of type string, null given in PATH/apps/groupfolders/lib/Folder/FolderManager.php:553
Stack trace:
#0 PATH/apps/groupfolders/lib/Folder/FolderManager.php(553): json_decode()
#1 PATH/apps/groupfolders/lib/Folder/FolderManager.php(87): OCA\GroupFolders\Folder\FolderManager->rowToFolder()
#2 PATH/apps/groupfolders/lib/Migration/WrongDefaultQuotaRepairStep.php(32): OCA\GroupFolders\Folder\FolderManager->getAllFolders()
#3 PATH/lib/private/Repair.php(107): OCA\GroupFolders\Migration\WrongDefaultQuotaRepairStep->run()
#4 PATH/lib/private/legacy/OC_App.php(574): OC\Repair->run()
#5 PATH/lib/private/App/AppManager.php(1059): OC_App::executeRepairSteps()
#6 PATH/lib/private/Updater.php(323): OC\App\AppManager->upgradeApp()
#7 PATH/lib/private/Updater.php(236): OC\Updater->doAppUpgrade()
#8 PATH/lib/private/Updater.php(100): OC\Updater->doUpgrade()
#9 PATH/core/Command/Upgrade.php(193): OC\Updater->upgrade()
#10 PATH/3rdparty/symfony/console/Command/Command.php(326): OC\Core\Command\Upgrade->execute()
#11 PATH/3rdparty/symfony/console/Application.php(1078): Symfony\Component\Console\Command\Command->run()
#12 PATH/3rdparty/symfony/console/Application.php(324): Symfony\Component\Console\Application->doRunCommand()
#13 PATH/3rdparty/symfony/console/Application.php(175): Symfony\Component\Console\Application->doRun()
#14 PATH/lib/private/Console/Application.php(187): Symfony\Component\Console\Application->run()
#15 PATH/console.php(90): OC\Console\Application->run()
#16 PATH/occ(33): require_once('...')
#17 {main}

Server configuration

Arch Linux, NGINX/PHP-FPM 8.4/ACPu, Valkey, Mariadb
Nextcloud version: 32.0.0.13
Team folders version: 20.1.0

[EnderArchery]

I have the same issue.
Although I did manage to upgrade with the app disabled.
(This was before the latest update was available and the enabled app caused error messages on the upgraded version)

BUT! I... now can't enable it anymore with the exact same error.

So my users cannot access these folders.

An unhandled exception has been thrown:
TypeError: json_decode(): Argument #1 ($json) must be of type string, null given in /mnt/md0/webroot/nextcloud/apps/groupfolders/lib/Folder/FolderManager.php:553
Stack trace:
#0 /mnt/md0/webroot/nextcloud/apps/groupfolders/lib/Folder/FolderManager.php(553): json_decode()
#1 /mnt/md0/webroot/nextcloud/apps/groupfolders/lib/Folder/FolderManager.php(87): OCA\GroupFolders\Folder\FolderManager->rowToFolder()
#2 /mnt/md0/webroot/nextcloud/apps/groupfolders/lib/Migration/WrongDefaultQuotaRepairStep.php(32): OCA\GroupFolders\Folder\FolderManager->getAllFolders()
#3 /mnt/md0/webroot/nextcloud/lib/private/Repair.php(107): OCA\GroupFolders\Migration\WrongDefaultQuotaRepairStep->run()
#4 /mnt/md0/webroot/nextcloud/lib/private/legacy/OC_App.php(574): OC\Repair->run()
#5 /mnt/md0/webroot/nextcloud/lib/private/Installer.php(548): OC_App::executeRepairSteps()
#6 /mnt/md0/webroot/nextcloud/lib/private/Installer.php(93): OC\Installer->installAppLastSteps()
#7 /mnt/md0/webroot/nextcloud/core/Command/App/Enable.php(91): OC\Installer->installApp()
#8 /mnt/md0/webroot/nextcloud/core/Command/App/Enable.php(64): OC\Core\Command\App\Enable->enableApp()
#9 /mnt/md0/webroot/nextcloud/3rdparty/symfony/console/Command/Command.php(326): OC\Core\Command\App\Enable->execute()
#10 /mnt/md0/webroot/nextcloud/3rdparty/symfony/console/Application.php(1078): Symfony\Component\Console\Command\Command->run()
#11 /mnt/md0/webroot/nextcloud/3rdparty/symfony/console/Application.php(324): Symfony\Component\Console\Application->doRunCommand()
#12 /mnt/md0/webroot/nextcloud/3rdparty/symfony/console/Application.php(175): Symfony\Component\Console\Application->doRun()
#13 /mnt/md0/webroot/nextcloud/lib/private/Console/Application.php(187): Symfony\Component\Console\Application->run()
#14 /mnt/md0/webroot/nextcloud/console.php(90): OC\Console\Application->run()
#15 /mnt/md0/webroot/nextcloud/occ(33): require_once('...')
#16 {main}                                                                              

[nursoda]

My workaround is a dirty downgrade. Assumptions/prerequisites:

• instance is in maintenance mode
• groupfolder was 20.0.1 before (if not, download the version you had before and adapt deletions in oc_migration)

Steps

• backup/dump table oc_migrations of the CLOUD DB
• delete from oc_migrations where version = '2000002Date20250927142943';
• move aside CLOUD/apps/groupfolders
• download and unpack https://github.com/nextcloud-releases/groupfolders/releases/download/v20.0.1/groupfolders-v20.0.1.tar.gz to CLOUD/apps
• occ maintenance:mode --off
• occ upgrade (should not be necessary if only groupfolders was upgraded and re-downgraded)

[small1]

One easy solution is to update the oc_group_folders table and set options to "" instead of null

update oc_group_folders set options="";

run occ upgrade
disable maintenance mode

That will solve it.

[come-nc]

Somehow the upgrade command gets incompatible versions of the classes from groupfolders, one from before upgrade and one from after :-/

[small1]

@come-nc can the options table be blank instead of NULL? (as i fixed my instances that broke)

[MichaIng]

Yes, this one is missing in the trace: 189fc98

Oh, the commit is not in v20.1.0 tag, or am I blind?

[come-nc]

#4011 is missing on stable32

[DaanSelen]

I managed to get this working when editing the /config/www/nextcloud/apps/groupfolders/lib/Folder/FolderManager.php

And specifically set this on line 553:

         private function rowToFolder(array $row): FolderDefinition {
                 $options = ""; //json_decode($row['options'], true);
                 return new FolderDefinition(

But I am afraid this will be overwritten on a following update.

[nursoda]

In software development it's human to miss a tag or overlook an edge case. But this (kind of) error would have been easily spotted if someone would have manually tested it by upgrading from any older version. API errors ("expecting N arguments but only got N-1" or "expecting type X but got NULL") can and should be noticed prior to releasing an app. Please either do manual tests (upgrades in this case) or enhance your CI pipeline accordingly (which is hard to set up in a way that all edge cases are included).

[MichaIng]

@DaanSelen
Note that your folder options will then always be empty, which might break related features.

Test this if you find time: #4038

@nursoda
Jep, I will test with 20.0.1 => 20.1.0 + above commit when home if not released yet. But the more the better, so this time all works well, after the previous release had the migration issue already.