Format AppNavigationForm.vue (refs #3099)#3188
Merged
susnux merged 1 commit intonextcloud:mainfrom Feb 27, 2026
Merged
Conversation
Collaborator
|
could you please sign off your commit?
Ideally please use conventional commits as well, e.g. |
don9x2E
force-pushed
the
chore/3099-appnav-format
branch
from
409aff1 to
b35c690
Compare
susnux
requested changes
Feb 27, 2026
Collaborator
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
I think this causes invalid HTML.
Because now this results in div within a ul, which is invalid and will cause accessibility issues.
don9x2E
force-pushed
the
chore/3099-appnav-format
branch
2 times, most recently
from
e90907b to
fed9346
Compare
susnux
reviewed
Feb 27, 2026
don9x2E
force-pushed
the
chore/3099-appnav-format
branch
from
fed9346 to
1ef61e8
Compare
don9x2E
force-pushed
the
chore/3099-appnav-format
branch
from
1ef61e8 to
0f232a6
Compare
Contributor
Author
|
Update: isn’t exported by @nextcloud/dialogs v6.4.2 (build failed). I replaced it with DialogBuilder + DialogSeverity to keep the same confirmation UX without the invalid HTML wrapper. |
Signed-off-by: don9x2E <revan@kakao.com>
don9x2E
force-pushed
the
chore/3099-appnav-format
branch
from
0f232a6 to
5891e3a
Compare
Collaborator
Maybe but we can also easily update to dialogs v7 |
susnux
approved these changes
Feb 27, 2026
Collaborator
|
/backport to stable5.2 |
2 tasks
backportbot
bot
removed
the
backport-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Format AppNavigationForm.vue to satisfy eslint/prettier
resolves Delete form only possible by super weird, click order #3099