Follow up IME option creation and delete dialog timing fixes#3185
Open
don9x2E wants to merge 3 commits intonextcloud:mainfrom
Open
Follow up IME option creation and delete dialog timing fixes#3185don9x2E wants to merge 3 commits intonextcloud:mainfrom
don9x2E wants to merge 3 commits intonextcloud:mainfrom
Conversation
The previous IME fix still allowed option-creation side effects from input events and did not fully protect Enter-driven actions during composition. This change switches local option creation to explicit user intent (Enter or add button after composition), keeps updates for existing options, and guards Enter/delete handlers with composition checks. It also moves focus to the next empty local option after creating one, and renders the delete-form confirmation dialog outside the actions slot so it opens immediately when clicked. Signed-off-by: don9x2E <revan@kakao.com>
- format AppNavigationForm.vue to satisfy prettier/eslint CI - register IconPlus in AnswerInput components used by explicit add button - update IME playwright test to assert explicit Enter intent before option creation Signed-off-by: don9x2E <revan@kakao.com>
Chartman123
reviewed
Feb 27, 2026
Collaborator
Chartman123
left a comment
Chartman123
left a comment
There was a problem hiding this comment.
Looks good, just some small comments :)
| <NcButton | ||
| :aria-label="t('forms', 'Add a new answer option')" | ||
| variant="tertiary" | ||
| :disabled="isIMEComposing || !canCreateLocalAnswer" |
Collaborator
There was a problem hiding this comment.
Why do you disable the button if we're not in an active IME composition? I think the button should also work for direct text inputs...
Chartman123
added
bug
Contributor
Author
|
Thanks for the review!
|
Signed-off-by: don9x2E <revan@kakao.com>
don9x2E
force-pushed
the
fix/ime-option-creation-followup
branch
from
cf90b95 to
972f2ae
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes after #3183 to address remaining real-world Korean IME issues and related UX regressions.
Enterafter composition end, or+button clickWhy this follow-up is needed
The initial IME patch improved composition handling, but in actual Korean IME use there were still edge cases where input-driven side effects could trigger option creation timing unexpectedly.
Switching local-row creation to explicit intent removes those composition timing race paths while preserving normal editing for existing options.
Trade-off
Auto-create-on-input for the local empty row is intentionally disabled for now to prioritize deterministic IME-safe behavior.
Validation