Skip to content

Add title on public page#315

Merged
skjnldsv merged 1 commit intomasterfrom
fix/public-header-title
May 5, 2020
Merged

Add title on public page#315
skjnldsv merged 1 commit intomasterfrom
fix/public-header-title

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 29, 2020

FInal fix #4

Capture d’écran_2020-04-29_19-06-46

@skjnldsv skjnldsv added bug Something isn't working design Related to the design 3. to review Waiting for reviews labels Apr 29, 2020
@skjnldsv skjnldsv self-assigned this Apr 29, 2020
@skjnldsv skjnldsv mentioned this pull request Apr 29, 2020
Closed
@jancborchardt
Copy link
Member

jancborchardt commented Apr 29, 2020

FInal fix #4

Capture d’écran_2020-04-29_19-06-46

In the subline we usually show the "shared-by" info as per the class name, for additional context: "shared by username"
That’s better than repeating the title of the form which already is shown in very large.

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 30, 2020 •
edited
Loading

In the subline we usually show the "shared-by" info as per the class name, for additional context: "shared by username"

Not anymore, we removed it for privacy reasons apparently
EDIT: only when specified on your displayname visibility settings

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 30, 2020
@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 30, 2020

Blocked by nextcloud/server#20744

@jancborchardt
Copy link
Member

jancborchardt commented Apr 30, 2020

In the subline we usually show the "shared-by" info as per the class name, for additional context: "shared by username"

Not anymore, we removed it for privacy reasons apparently
EDIT: only when specified on your displayname visibility settings

Blocker is merged, can you adjust the subline then to show the "shared by username" info? If it’s disabled in the displayname visibility settings, just don’t show any subline.

@jancborchardt jancborchardt force-pushed the fix/public-header-title branch from ca566cd to fa85dd6 Compare April 30, 2020 22:17
@jancborchardt jancborchardt added this to the 2.0 milestone May 1, 2020
@skjnldsv skjnldsv force-pushed the fix/public-header-title branch from fa85dd6 to ab1503b Compare May 4, 2020 15:26
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 4, 2020
@skjnldsv
Copy link
Member Author

skjnldsv commented May 4, 2020 •
edited
Loading

Rebased, ready to go @jancborchardt @jotoeri :)

image

@skjnldsv skjnldsv force-pushed the fix/public-header-title branch from ab1503b to 8359300 Compare May 4, 2020 15:44
@codecov-io
Copy link

codecov-io commented May 4, 2020 •
edited
Loading

Codecov Report

Merging #315 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #315   +/-   ##
========================================
  Coverage      0.00%   0.00%           
- Complexity      173     181    +8     
========================================
  Files            18      18           
  Lines           965    1001   +36     
========================================
- Misses          965    1001   +36
Impacted Files Coverage Δ Complexity Δ
lib/AppInfo/Application.php 0.00% <ø> (ø) 1.00 <0.00> (ø)
lib/Controller/ApiController.php 0.00% <0.00%> (ø) 63.00 <11.00> (+2.00)
lib/Controller/PageController.php 0.00% <0.00%> (ø) 16.00 <0.00> (-8.00)
lib/Controller/SystemController.php 0.00% <ø> (ø) 8.00 <0.00> (ø)
lib/Db/FormMapper.php 0.00% <ø> (ø) 5.00 <0.00> (ø)
lib/Db/OptionMapper.php 0.00% <ø> (ø) 4.00 <0.00> (ø)
lib/Db/SubmissionMapper.php 0.00% <ø> (ø) 5.00 <0.00> (ø)
lib/Service/FormsService.php 0.00% <0.00%> (ø) 22.00 <14.00> (+14.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b53cb...5b9f65f. Read the comment docs.

jotoeri
jotoeri reviewed May 4, 2020
View reviewed changes
jotoeri
jotoeri reviewed May 4, 2020
View reviewed changes
@jotoeri jotoeri self-requested a review May 4, 2020 18:40
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 5, 2020
@skjnldsv
Add title on public page
5b9f65f 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/public-header-title branch from 9cfc113 to 5b9f65f Compare May 5, 2020 06:55
@skjnldsv skjnldsv merged commit 86de8c0 into master May 5, 2020
@skjnldsv skjnldsv deleted the fix/public-header-title branch May 5, 2020 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jotoeri jotoeri jotoeri approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working design Related to the design

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

Don't show Nextcloud Toolbar with all apps

4 participants

@skjnldsv @jancborchardt @codecov-io @jotoeri