Skip to content

Add pagination for submissions #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Koc
Copy link
Collaborator

@Koc Koc commented Apr 18, 2025

This PR adds pagination for submissions list page. Few notes about implementation:

  • It's not affect "Summary" tab
  • Pagination works on the server
  • There is an extra "search" field that used for filtering submissions
🔍 Preview

image
image

@Koc Koc requested review from susnux, Chartman123 and Copilot April 18, 2025 14:44
@Koc Koc self-assigned this Apr 18, 2025
Copilot

This comment was marked as outdated.

Copy link
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Koc

nice start, here are a few comments:

  • I think we should split up the filtering from the rest of the pagination block and move it up to the right of the summary/responses switch
    grafik
  • The page dropdown is placed too high, there should be more spacing on top of it
  • floating style looks odd to me, should be just embedded into the page
  • page selection should be below the submissions or above and below but not only above them.
  • A max of 50 items seems too big for me as a default. You'd still have to scroll a lot before you reach the end of the page
  • At best we should make the item limit configurable (user setting)

Regarding the pagination in general: I think we should only fetch the currently shown submissions from the API. But in this case the filtering will no longer be able to work only in the front-end. So more adjustments needed then...

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc Koc force-pushed the feature/add-submission-pagination branch 2 times, most recently from 3b059eb to a8ee312 Compare April 20, 2025 23:39
@Koc
Copy link
Collaborator Author

Koc commented Apr 20, 2025

Hey @Chartman123 , thank you for quick feedback, very appreciated!

I've did some changes and updated screenshots in the PR description. So, I've moved pagination to backend and added extra parameter for full text search. For some reason it not works for me 😕 . Please help, feel free to push.

@Koc Koc force-pushed the feature/add-submission-pagination branch from a8ee312 to c10b122 Compare April 20, 2025 23:43
@Chartman123 Chartman123 force-pushed the feature/add-submission-pagination branch 6 times, most recently from 85c7892 to 07600cc Compare April 21, 2025 13:42
@Koc Koc force-pushed the feature/add-submission-pagination branch 3 times, most recently from 62b2f1f to 205dfea Compare April 21, 2025 22:34
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 35 lines in your changes missing coverage. Please review.

Project coverage is 42.45%. Comparing base (e88ba60) to head (2bcdcd2).
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2710      +/-   ##
============================================
- Coverage     43.55%   42.45%   -1.11%     
- Complexity      908      912       +4     
============================================
  Files            78       78              
  Lines          3391     3373      -18     
============================================
- Hits           1477     1432      -45     
- Misses         1914     1941      +27     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Koc Koc force-pushed the feature/add-submission-pagination branch 2 times, most recently from 15f1e16 to 0319a73 Compare April 21, 2025 22:49
Koc and others added 2 commits April 22, 2025 00:56
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Koc Koc force-pushed the feature/add-submission-pagination branch from 0319a73 to 2bcdcd2 Compare April 21, 2025 22:56
@Koc Koc requested a review from Copilot April 22, 2025 09:20
Copilot

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants