-
Notifications
You must be signed in to change notification settings - Fork 104
Add pagination for submissions #2710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Koc
nice start, here are a few comments:
- I think we should split up the filtering from the rest of the pagination block and move it up to the right of the summary/responses switch
- The page dropdown is placed too high, there should be more spacing on top of it
floating
style looks odd to me, should be just embedded into the page- page selection should be below the submissions or above and below but not only above them.
- A max of 50 items seems too big for me as a default. You'd still have to scroll a lot before you reach the end of the page
- At best we should make the item limit configurable (user setting)
Regarding the pagination in general: I think we should only fetch the currently shown submissions from the API. But in this case the filtering will no longer be able to work only in the front-end. So more adjustments needed then...
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
3b059eb
to
a8ee312
Compare
Hey @Chartman123 , thank you for quick feedback, very appreciated! I've did some changes and updated screenshots in the PR description. So, I've moved pagination to backend and added extra parameter for full text search. For some reason it not works for me 😕 . Please help, feel free to push. |
a8ee312
to
c10b122
Compare
85c7892
to
07600cc
Compare
62b2f1f
to
205dfea
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2710 +/- ##
============================================
- Coverage 43.55% 42.45% -1.11%
- Complexity 908 912 +4
============================================
Files 78 78
Lines 3391 3373 -18
============================================
- Hits 1477 1432 -45
- Misses 1914 1941 +27 🚀 New features to boost your workflow:
|
15f1e16
to
0319a73
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
0319a73
to
2bcdcd2
Compare
This PR adds pagination for submissions list page. Few notes about implementation:
🔍 Preview