Mount menu entry into Vue user menu - #816
Merged
Merged
Conversation
Pytal
requested review from
JuliaKirschenheuter,
nickvergessen,
skjnldsv and
szaimen
January 27, 2023 02:29
Member
Author
|
/backport to stable25 |
Pytal
force-pushed
the
enh/a11y-user-menu-id
branch
4 times, most recently
from
January 27, 2023 22:50
830594e to
19c436e
Compare
Collaborator
Pytal
force-pushed
the
enh/a11y-user-menu-id
branch
from
January 31, 2023 03:22
19c436e to
d08a6ac
Compare
Pytal
force-pushed
the
enh/a11y-user-menu-id
branch
2 times, most recently
from
February 4, 2023 00:24
52afe29 to
8cfd9d9
Compare
Member
Author
|
Rebased Lint is now passing https://github.com/nextcloud/firstrunwizard/actions/runs/4088986130/jobs/7051216647 with schema update in nextcloud/server#36508 |
JuliaKirschenheuter
approved these changes
Feb 6, 2023
JuliaKirschenheuter
left a comment
JuliaKirschenheuter
left a comment
Contributor
There was a problem hiding this comment.
can't reproduce nextcloud/server#36232 (comment), but probably have no case
Member
Author
|
Merge after nextcloud/server#36232 |
szaimen
approved these changes
Feb 7, 2023
szaimen
left a comment
szaimen
left a comment
Collaborator
There was a problem hiding this comment.
Tested together with nextcloud/server#36232 and works now but didnt review the code.
(Looks like the internal server issue was somehow caused by the viewer app not being installed).
- The user menu entry should not show a link when it is meant to open a modal Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
enh/a11y-user-menu-id
branch
from
February 9, 2023 19:08
8cfd9d9 to
02c2e5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
Allow empty route for navigation entries聽server#36449