-
Notifications
You must be signed in to change notification settings - Fork 54
Video intro #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video intro #222
Conversation
|
Small questions as I faced this multiple times:
Otherwise, good job :) |
665527a to
e41a6d4
Compare
For the original one, no idea. For the webm one, I did with
I discussed that with @rullzer So we have the default one with h264 and a webm fallback for other browsers. We reuse the one from the default files to not ship it twice. |
guess it should be fine :) |
e41a6d4 to
b199dd9
Compare
|
All addressed, CI failure is unrelated (fix is in #221) |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
b199dd9 to
bfe1076
Compare
|
Tests do 💥 |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Still needs some proper preloading of the image, but otherwise should be ready to go.