Skip to content

Conversation

@juliusknorr
Copy link
Member

Still needs some proper preloading of the image, but otherwise should be ready to go.

@skjnldsv
Copy link
Member

skjnldsv commented Dec 3, 2019

Small questions as I faced this multiple times:

  • Who encoded the videos?
  • With what codec?
  • (Why are they stored from two different locations?)

Otherwise, good job :)

@juliusknorr
Copy link
Member Author

Who encoded the videos?

For the original one, no idea. For the webm one, I did with ffmpeg -i Nextcloud\ intro.mp4 -c:v libvpx -crf 15 -b:v 1M -c:a libvorbis Nextcloud.webm

(Why are they stored from two different locations?)

I discussed that with @rullzer So we have the default one with h264 and a webm fallback for other browsers. We reuse the one from the default files to not ship it twice.

@skjnldsv
Copy link
Member

skjnldsv commented Dec 3, 2019

For the original one, no idea. For the webm one, I did with ffmpeg -i Nextcloud\ intro.mp4 -c:v libvpx -crf 15 -b:v 1M -c:a libvorbis Nextcloud.webm

guess it should be fine :)

@juliusknorr
Copy link
Member Author

All addressed, CI failure is unrelated (fix is in #221)

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@rullzer
Copy link
Member

rullzer commented Dec 4, 2019

Tests do 💥

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added this to the Nextcloud 18 milestone Dec 5, 2019
@juliusknorr juliusknorr merged commit 906bde6 into master Dec 5, 2019
@juliusknorr juliusknorr deleted the video-intro branch December 5, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants