Use correct CSS URL, remove default marked settings and change to GFM rendering #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rendering * improves the list rendering for system report (see app list) Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
commented
May 6, 2019
| .html(DOMPurify.sanitize( | ||
| marked(content, { | ||
| renderer: renderer, | ||
| gfm: false, |
There was a problem hiding this comment.
This is the only non-default value here. Default is true and thus it fixes the stuff in here.
MorrisJobke
commented
May 6, 2019
| OC_Util::addVendorScript('core', 'marked/marked.min'); | ||
| OCP\Util::addScript('files_texteditor', 'public-share'); | ||
| OCP\Util::addStyle('files_texteditor', '../build/public-share'); | ||
| OCP\Util::addStyle('files_texteditor', 'public-share'); |
There was a problem hiding this comment.
Looks like a wrong c&p because only JS is placed in there. SCSS is processed by NC and thus already at the correct location.
|
/backport to stable16 |
|
/backport to stable15 |
|
/backport to stable14 |
skjnldsv
approved these changes
May 6, 2019
|
backport to stable16 in #150 |
|
backport to stable15 in #151 |
|
backport to stable14 in #152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before and after:
Be aware that this only works if the markdown editor app is not enabled.