Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add workflow to notify of changed viewer.html #810

Merged
merged 1 commit into from
Aug 22, 2023
Merged

add workflow to notify of changed viewer.html #810

merged 1 commit into from
Aug 22, 2023

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Aug 21, 2023

Address #798 (comment)

@szaimen szaimen added this to the Nextcloud 28 milestone Aug 21, 2023
@szaimen szaimen mentioned this pull request Aug 21, 2023
Merged
@szaimen szaimen force-pushed the enh/noid/add-viewer-workflow branch from ab37efb to 229d101 Compare August 21, 2023 17:18
@szaimen szaimen marked this pull request as ready for review August 21, 2023 17:18
@szaimen szaimen force-pushed the enh/noid/add-viewer-workflow branch 2 times, most recently from 64221ae to 4e0d164 Compare August 21, 2023 17:27
@szaimen szaimen requested a review from danxuliu August 21, 2023 17:28
danxuliu
danxuliu reviewed Aug 21, 2023
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

I have some minor nitpicking, though :-)

.github/workflows/update-viewer.yml Outdated Show resolved Hide resolved
.github/workflows/update-viewer.yml Outdated Show resolved Hide resolved
.github/workflows/update-viewer.yml Outdated Show resolved Hide resolved
.github/workflows/update-viewer.yml Outdated Show resolved Hide resolved
@szaimen szaimen requested a review from danxuliu August 21, 2023 19:56
@szaimen @danxuliu
add workflow to notify of changed viewer.html
fc332de 
Signed-off-by: Simon L <szaimen@e.mail.de>
@danxuliu danxuliu force-pushed the enh/noid/add-viewer-workflow branch from 5fc0772 to fc332de Compare August 22, 2023 11:58
danxuliu
danxuliu approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I have rebased to fix up the first commit with the second one, as the second one only modified things added in the first commit and it was not relevant on its own.

@danxuliu danxuliu merged commit 980901c into master Aug 22, 2023
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/add-viewer-workflow branch August 22, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

Assignees
No one assigned
Labels
3. to review enhancement
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
2 participants
@szaimen @danxuliu