Skip to content

Conversation

@PVince81
Copy link
Member

No description provided.

@PVince81 PVince81 added this to the Nextcloud 23.0.12 milestone Nov 21, 2022
@PVince81 PVince81 self-assigned this Nov 21, 2022
@blizzz blizzz mentioned this pull request Nov 21, 2022
8 tasks
@nickvergessen
Copy link
Member

https://github.com/nextcloud/files_pdfviewer/blob/stable23/package.json#L35-L38

is broken, Needs a patch like nextcloud/activity@3962dc1

@PVince81

This comment was marked as resolved.

@PVince81

This comment was marked as resolved.

@nickvergessen

This comment was marked as resolved.

@PVince81

This comment was marked as resolved.

@PVince81 PVince81 force-pushed the stable23-update-some-libs branch from 7890f76 to 9084754 Compare November 21, 2022 15:59
@nextcloud-command nextcloud-command force-pushed the stable23-update-some-libs branch from 9084754 to 4389e2a Compare November 21, 2022 16:18
@nickvergessen

This comment was marked as resolved.

@PVince81

This comment was marked as resolved.

@nickvergessen

This comment was marked as resolved.

@PVince81

This comment was marked as resolved.

@nickvergessen

This comment was marked as resolved.

@PVince81

This comment was marked as resolved.

@PVince81 PVince81 assigned skjnldsv and unassigned PVince81 Nov 21, 2022
@skjnldsv
Copy link
Member

  • Fix compilation by aligning the "vue" and "vue-template-compiler" versions: npm install @nextcloud/webpack-vue-config@5

We do not do major upgrades on stable branches.

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the stable23-update-some-libs branch from 4389e2a to b62d6e3 Compare November 22, 2022 08:10
@skjnldsv skjnldsv changed the title [stable23] Update some libs [stable23] Audit fix and pin npm/node engines Nov 22, 2022
@PVince81
Copy link
Member Author

@skjnldsv how did you manage to compile ?

when I run npm ci && npm run build I get this:

Error: 

Vue packages version mismatch:

- vue@2.7.13 (/srv/www/htdocs/server/node_modules/vue/dist/vue.runtime.common.js)
- vue-template-compiler@2.6.14 (/srv/www/htdocs/server/apps-extra/files_pdfviewer/node_modules/vue-template-compiler/package.json)

@PVince81
Copy link
Member Author

oh wait, it's only now that I see that it's taking vue from node_modules of the server repo, I didn't realize that I needed the server to be on stable23 as well for compilation

@skjnldsv
Copy link
Member

oh wait, it's only now that I see that it's taking vue from node_modules of the server repo, I didn't realize that I needed the server to be on stable23 as well for compilation

You should not nest them, each need their own node modules

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the stable23-update-some-libs branch from bbbbc28 to e48a42e Compare November 22, 2022 08:34
@PVince81
Copy link
Member Author

You should not nest them, each need their own node modules

I didn't do anything. It does it on its own somehow. Weird.

@skjnldsv skjnldsv merged commit 27b72cb into stable23 Nov 22, 2022
@skjnldsv skjnldsv deleted the stable23-update-some-libs branch November 22, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants