- 
                Notifications
    You must be signed in to change notification settings 
- Fork 53
[stable23] Audit fix and pin npm/node engines #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| https://github.com/nextcloud/files_pdfviewer/blob/stable23/package.json#L35-L38 is broken, Needs a patch like nextcloud/activity@3962dc1 | 
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
7890f76    to
    9084754      
    Compare
  
    9084754    to
    4389e2a      
    Compare
  
    
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
| 
 We do not do major upgrades on stable branches. | 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
4389e2a    to
    b62d6e3      
    Compare
  
    | @skjnldsv how did you manage to compile ? when I run   | 
| oh wait, it's only now that I see that it's taking vue from node_modules of the server repo, I didn't realize that I needed the server to be on stable23 as well for compilation | 
| 
 You should not nest them, each need their own node modules | 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
bbbbc28    to
    e48a42e      
    Compare
  
    | 
 I didn't do anything. It does it on its own somehow. Weird. | 
No description provided.