[stable20] Fix PDF viewer failing on Edge (not based on Chromium) #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
danxuliu,
juliusknorr and
rullzer
Since version v2.4.456 the PDF.js library is published as two different packages, a non-translated/non-polyfilled build for modern browsers and an ES5 compatible build for older browsers. The PDF viewer was using the build for modern browsers, so it did not work, for example, on Edge (the original version not based on Chromium). This has been changed to use the ES5 build instead for maximum compatibility. Unfortunately, the ES5 build requires allowing "unsafe-eval" in the iframe where the PDF.js library is loaded. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
backport/297/stable20
branch
from
3581f9e to
312495a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #297