Repository navigation
[stable34] Add a vitest harness for the front-end - #1565
Merged
Merged
Conversation
The app had no JavaScript tests at all. Vitest runs the specs in "tests/js", "make test" and the "node-test" workflow run it, and the README no longer claims that "make test" runs everything, since the PHP tests need a Nextcloud instance around them. The workflow follows the same shape as the other npm ones in this repository: a "changes" job filtering on paths, the real job gated on it, and a "summary" job that always reports so the check can be a required one without getting stuck pending on a pull request that touches nothing relevant. The specs added here hold on the current code: they check that every viewer parameter the component reads is provided by the template, and that the template still has the same elements as the pdf.js viewer it is a copy of. The regression tests for the individual fixes come with those fixes. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
backport/1560/stable34
branch
from
September 8, 2026 13:10
6166070 to
90b450b
Compare
CarlSchwan
marked this pull request as ready for review
September 8, 2026 13:15
susnux
approved these changes
Sep 8, 2026
Contributor
|
Does only contain test files - release bundle not changed (checked this!). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1560
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.