[stable31] Remove custom handling for public share pages with single files #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/compile / |
Since Nextcloud 31 the public share pages for single files and folders were unified, and public single file shares now show a file list with a single file. Due to that it is no longer needed to explicitly inject the PDF viewer in public shage pages or adjust the style, as the PDF viewer will be loaded as needed by the Viewer component. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Since Nextcloud 31 the "hideDownload" HTML element no longer exists. Between Nextcloud 31.0.0 and 31.0.4 (both included) "hide download" behaved as "prevent download", so the PDF viewer could not show the file at all in that case. In Nextcloud 31.0.5 the "hide download" behaviour was restored, although the setting is now provided as a WebDAV property (which is included in the file data), so the PDF viewer had to be adjusted to that. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Even if the PDF viewer was able to show the file when the download is hidden, before Nextcloud 31 the custom handling for public shares of a single file opened it in Nextcloud Office instead. For consistency with the previous behaviour now Nextcloud Office is used again in that case. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
szaimen
force-pushed
the
backport/1164/stable31-remove-custom-handling-for-public-share-pages
branch
from
15efbdb to
23799e3
Compare
|
/compile amend / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
backport/1164/stable31-remove-custom-handling-for-public-share-pages
branch
from
23799e3 to
2cd6f08
Compare
danxuliu
deleted the
backport/1164/stable31-remove-custom-handling-for-public-share-pages
branch
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #1204
Backport of #1164
Kept as draft until #1204 is merged and this one rebased on stable31, and until #1164 is reviewed and approved, but opening it beforehand to have it ready if it is approved without requiring changes.